ClickHouse: Normalize one batch at a time #2219
Open
+85
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Nov 6, 2024
heavycrystal
reviewed
Nov 6, 2024
| rawTbl := c.getRawTableName(flowJobName) | ||
|
|
||
| q := fmt.Sprintf( | ||
| `SELECT DISTINCT _peerdb_destination_table_name FROM %s WHERE _peerdb_batch_id = %d`, |
There was a problem hiding this comment.
is it possible to craft a query to aggregate and fetch distinct tables for all batches at once
There was a problem hiding this comment.
That is the current behaviour and this PR changes it to get it for each batch
Do you want this function to be called higher up for all batches and pass a map of batchId:[table1,table2..] to syncTablesInThisBatch()
There was a problem hiding this comment.
yes, reduces queries we run
serprex
reviewed
Nov 6, 2024
| } | ||
|
|
||
| rawTbl := c.getRawTableName(req.FlowJobName) | ||
|
|
||
| // model the raw table data as inserts. | ||
| for _, tbl := range destinationTableNames { | ||
| // SELECT projection FROM raw_table WHERE _peerdb_batch_id > normalize_batch_id AND _peerdb_batch_id <= sync_batch_id |
serprex
reviewed
Nov 6, 2024
Comment on lines
+272
to
+273
| err = c.syncTablesInThisBatch(ctx, req, rawTbl, batchID) | ||
| if err != nil { |
There was a problem hiding this comment.
Suggested change
| err = c.syncTablesInThisBatch(ctx, req, rawTbl, batchID) | |
| if err != nil { | |
| if err := c.syncTablesInThisBatch(ctx, req, rawTbl, batchID); err != nil { |
serprex
reviewed
Nov 6, 2024
Comment on lines
+279
to
+280
| err = c.UpdateNormalizeBatchID(ctx, req.FlowJobName, batchID) | ||
| if err != nil { |
There was a problem hiding this comment.
Suggested change
| err = c.UpdateNormalizeBatchID(ctx, req.FlowJobName, batchID) | |
| if err != nil { | |
| if err := c.UpdateNormalizeBatchID(ctx, req.FlowJobName, batchID); err != nil { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with: