Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded crosshairs from brainsprite #943

Open
tsalo opened this issue Sep 22, 2023 · 2 comments
Open

Remove hardcoded crosshairs from brainsprite #943

tsalo opened this issue Sep 22, 2023 · 2 comments
Assignees
Labels
dcan DCAN-related issues and PRs enhancement New feature or request

Comments

@tsalo
Copy link
Member

tsalo commented Sep 22, 2023

Summary

It would be great to remove the green and blue lines/planes from the brainsprite (see below).

image

Additional details

Improved visualization.

Next steps

I think this will require modification of the workbench scene file(s), which I do not have the expertise to do.

@tsalo tsalo added the enhancement New feature or request label Sep 22, 2023
@tsalo tsalo self-assigned this Sep 22, 2023
@tsalo tsalo added the dcan DCAN-related issues and PRs label Sep 26, 2023
@tsalo
Copy link
Member Author

tsalo commented Oct 10, 2023

@madisoth is there anyone in the DCAN lab who can do this?

@tsalo
Copy link
Member Author

tsalo commented Oct 20, 2023

The original scene files shared by the DCAN team were massive (~200 MB I believe) and wouldn't fit well into the GitHub repo, so when I originally switched from the brainsprite code to using wb_command I ended up manually going through those files and removing anything that was modality (T1w vs. T2w) or slice-specific, which dramatically reduced the size of the files. If possible, it would be great to retain that change in the modified files.

One trick might be to modify the original scene files and share those, and then I could do a diff between the original and modified versions to see what changes actually fixed the crosshair issue. I could then isolate those changes and copy them over to the reduced scene file that's in the repo.

@tsalo tsalo assigned madisoth and unassigned tsalo Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dcan DCAN-related issues and PRs enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants