-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Improve readability of conditional passes #1194
base: main
Are you sure you want to change the base?
[Frontend] Improve readability of conditional passes #1194
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1194 +/- ##
==========================================
+ Coverage 96.72% 97.95% +1.23%
==========================================
Files 56 77 +21
Lines 6800 11331 +4531
Branches 780 978 +198
==========================================
+ Hits 6577 11099 +4522
- Misses 173 182 +9
Partials 50 50 ☔ View full report in Codecov by Sentry. |
🥳 Thanks! Apart from readability I like how these lists are no longer just globals floating around. Is it possible to increase some test coverage to address codecov? |
I am a bit opposed to creating unit tests for these functions. They are so simple and it would just make us recreate the list in the tests. This would mean having to modify tests whenever we change the list of passes to run. |
d81550f
to
03da19f
Compare
Context: We are using the term
pipeline
a lot. We are also defining compilation pipelines at the module level and modifying them depending on configuration options.Description of the Change: Change the compilation pipeline into stages and improve readability of passes that are conditional on compile time options.
Benefits: Readability.