[Draft] Ion dialect #1260
Draft
[Draft] Ion dialect #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-73704] |
mlxd
requested changes
Nov 8, 2024
| @@ -0,0 +1,23 @@ | |||
| // Copyright 2023 Xanadu Quantum Technologies Inc. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2023 Xanadu Quantum Technologies Inc. | |
| // Copyright 2024 Xanadu Quantum Technologies Inc. |
| @@ -0,0 +1,21 @@ | |||
| // Copyright 2023 Xanadu Quantum Technologies Inc. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2023 Xanadu Quantum Technologies Inc. | |
| // Copyright 2024 Xanadu Quantum Technologies Inc. |
| @@ -0,0 +1,45 @@ | |||
| // Copyright 2022-2023 Xanadu Quantum Technologies Inc. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2022-2023 Xanadu Quantum Technologies Inc. | |
| // Copyright 2024 Xanadu Quantum Technologies Inc. |
| @@ -0,0 +1,224 @@ | |||
| // Copyright 2022-2023 Xanadu Quantum Technologies Inc. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2022-2023 Xanadu Quantum Technologies Inc. | |
| // Copyright 2024 Xanadu Quantum Technologies Inc. |
Comment on lines
+15
to
+20
| #include "mlir/Dialect/Arith/IR/Arith.h" | ||
| #include "mlir/IR/Builders.h" | ||
| #include "mlir/IR/OpImplementation.h" | ||
| #include "llvm/ADT/StringSet.h" | ||
| #include "llvm/ADT/TypeSwitch.h" | ||
| #include <optional> |
There was a problem hiding this comment.
Suggested change
| #include "mlir/Dialect/Arith/IR/Arith.h" | |
| #include "mlir/IR/Builders.h" | |
| #include "mlir/IR/OpImplementation.h" | |
| #include "llvm/ADT/StringSet.h" | |
| #include "llvm/ADT/TypeSwitch.h" | |
| #include <optional> | |
| #include <optional> | |
| #include "mlir/Dialect/Arith/IR/Arith.h" | |
| #include "mlir/IR/Builders.h" | |
| #include "mlir/IR/OpImplementation.h" | |
| #include "llvm/ADT/StringSet.h" | |
| #include "llvm/ADT/TypeSwitch.h" |
System/standard include -- ecosystem includes -- local includes
Comment on lines
+17
to
+27
| #include "mlir/Dialect/Bufferization/IR/AllocationOpInterface.h" | ||
| #include "mlir/IR/BuiltinTypes.h" | ||
| #include "mlir/IR/Dialect.h" | ||
| #include "mlir/IR/OpDefinition.h" | ||
| #include "mlir/IR/PatternMatch.h" | ||
| #include "mlir/Interfaces/ControlFlowInterfaces.h" | ||
| #include "mlir/Interfaces/SideEffectInterfaces.h" | ||
| #include "mlir/Support/LogicalResult.h" | ||
| #include "llvm/ADT/StringRef.h" | ||
| #include "llvm/Support/ErrorHandling.h" | ||
| #include <optional> |
There was a problem hiding this comment.
Suggested change
| #include "mlir/Dialect/Bufferization/IR/AllocationOpInterface.h" | |
| #include "mlir/IR/BuiltinTypes.h" | |
| #include "mlir/IR/Dialect.h" | |
| #include "mlir/IR/OpDefinition.h" | |
| #include "mlir/IR/PatternMatch.h" | |
| #include "mlir/Interfaces/ControlFlowInterfaces.h" | |
| #include "mlir/Interfaces/SideEffectInterfaces.h" | |
| #include "mlir/Support/LogicalResult.h" | |
| #include "llvm/ADT/StringRef.h" | |
| #include "llvm/Support/ErrorHandling.h" | |
| #include <optional> | |
| #include <optional> | |
| #include "mlir/Dialect/Bufferization/IR/AllocationOpInterface.h" | |
| #include "mlir/IR/BuiltinTypes.h" | |
| #include "mlir/IR/Dialect.h" | |
| #include "mlir/IR/OpDefinition.h" | |
| #include "mlir/IR/PatternMatch.h" | |
| #include "mlir/Interfaces/ControlFlowInterfaces.h" | |
| #include "mlir/Interfaces/SideEffectInterfaces.h" | |
| #include "mlir/Support/LogicalResult.h" | |
| #include "llvm/ADT/StringRef.h" | |
| #include "llvm/Support/ErrorHandling.h" |
Just a reordering of imports to follow standard--module--local rules.
|
Hello. You may have forgotten to update the changelog!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new functions and code must be clearly commented and documented.
Ensure that code is properly formatted by running
make format.The latest version of black and
clang-format-14are used in CI/CD to check formatting.All new features must include a unit test.
Integration and frontend tests should be added to
frontend/test,Quantum dialect and MLIR tests should be added to
mlir/test, andRuntime tests should be added to
runtime/tests.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: