Fixing string representations in tests #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul0403
reviewed
Nov 8, 2024
|
Hello. You may have forgotten to update the changelog!
|
lillian542
approved these changes
Nov 8, 2024
albi3ro
added a commit
to PennyLaneAI/pennylane
that referenced
this pull request
Nov 11, 2024
**PLEASE READ BEFORE MERGING** Immediately after this PR is merged into PL, [this one](PennyLaneAI/catalyst#1292) should be marked as ready for review and merged into Catalyst to fix the tests. **Context:** The string representation format of some operators is slightly different from others. This is because some do not have their own string representation. Furthermore, the output of the Hadamard operator should be updated since its string representation recently changed. **Description of the Change:** - Change the output in the doc of the `qml.Hadamard` operator, since its string representation changed during the previous release - Add a string representation for the `qml.S` operator and change the output in the doc - Add a string representation for the `qml.T` operator and change the output in the doc - Add a string representation for the `qml.SX` operator and change the output in the doc **Benefits:** Correct doc output and more consistency among string representation for non-parametrized single wire operators. **Possible Drawbacks:** This change was performed during the feature freeze before the release of PL 0.39, but it had to be reverted because of a single test in Catalyst that failed (the test uses the string representation to verify the result). It is necessary to create a small PR in Catalyst to fix such a test and link it to this story after the PL PR is merged. **Related GitHub Issues:** None. **Related Shortcut Stories:** [sc-77632] --------- Co-authored-by: Christina Lee <[email protected]>
|
@joeycarter Is this the "changed-before-release-then-changed-back" string test you mentioned? |
Yes exactly, this PR replaces my old one here: #1263 |
joeycarter
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: This PR in core PennyLane slightly improves the string representations for some operators. One example is:
"Adjoint(S(wires=[0]) + T(wires=[0]))"->"Adjoint(S(0) + T(0))". Catalyst contains a few tests that check these string representations, so these tests must be updated.Description of the Change: For the above reason, we update string representations for all failing tests.
Benefits: Catalyst works again.
Possible Drawbacks: None that I can think of.
Related GitHub Issues: None.
Related Shortcut Stories: [sc-77632]