Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release to compat workflows. #531

Merged
merged 16 commits into from
Oct 27, 2023
Merged

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Oct 26, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
The compatibility workflows only target combinations of stable/latest but it is useful to test release candidate against release candidate (PennyLane).

Description of the Change:
Add release/release compatibility workflow.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bebe551) 99.24% compared to head (cf8225c) 97.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   99.24%   97.37%   -1.88%     
==========================================
  Files         165      145      -20     
  Lines       21677    17322    -4355     
==========================================
- Hits        21513    16867    -4646     
- Misses        164      455     +291     
Files Coverage Δ
pennylane_lightning/core/_version.py 100.00% <100.00%> (ø)

... and 48 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr marked this pull request as ready for review October 26, 2023 21:05
@vincentmr vincentmr requested a review from a team October 26, 2023 21:05
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a simple suggestion to allow support for all shells, local or remote.

.github/workflows/tests_gpu_cu11.yml Outdated Show resolved Hide resolved
.github/workflows/tests_gpu_cu11.yml Outdated Show resolved Hide resolved
.github/workflows/tests_gpu_kokkos.yml Outdated Show resolved Hide resolved
.github/workflows/tests_gpu_kokkos.yml Outdated Show resolved Hide resolved
.github/workflows/tests_linux.yml Outdated Show resolved Hide resolved
.github/workflows/tests_linux.yml Outdated Show resolved Hide resolved
.github/workflows/tests_linux.yml Outdated Show resolved Hide resolved
.github/workflows/tests_linux.yml Outdated Show resolved Hide resolved
.github/workflows/tests_without_binary.yml Outdated Show resolved Hide resolved
.github/workflows/tests_without_binary.yml Outdated Show resolved Hide resolved
@vincentmr vincentmr requested a review from mlxd October 27, 2023 14:49
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vincentmr

@vincentmr vincentmr merged commit c4afbd0 into master Oct 27, 2023
75 of 76 checks passed
@vincentmr vincentmr deleted the plugin_test_matrix/add_release branch October 27, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants