Fix Windows wheels #693
Merged
Fix Windows wheels #693
+49
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ennylane-lightning into fix_Windows_wheels
…ennylane-lightning into fix_Windows_wheels
|
[sc-59304] |
…ennylane-lightning into fix_Windows_wheels
vincentmr
force-pushed
the
fix_Windows_wheels
branch
from
d7e1fdf
to
505bb39
Compare
vincentmr
approved these changes
Apr 23, 2024
…ennylane-lightning into fix_Windows_wheels
…ennylane-lightning into fix_Windows_wheels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: We add tests for Windows Wheels, fix ill-defined caching, and set the proper backend for LKokkos wheels.
Description of the Change: Move tests to happen after patching the wheels, set a proper key for cache (compatible with Windows system), and set environment variables to set the proper backend to be built.
Building the LKokkos wheels is out-of-scope for this PR, and will be revisited when sensible.
Benefits: Proper wheels tested and working as intended.
Possible Drawbacks: For now we will not be building wheels for LKokkos on Windows.
Related GitHub Issues: