assignment: add ISWAP functionality and unit tests #749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.
Ensure that the test suite passes, by running make test.
Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Add ISWAP functionality in BasicGateFunctors.hpp
Add ISWAP unit tests in :
StateVectorKokkos::applyMatrix/Param-Operation
StateVectorKokkos::applyISWAP
Passed updated tests in lightning_kokkos_gates_test_runner
Benefits:
New ISWAP feature available and can run on multiple HPC platforms.
Possible Drawbacks:
Python layer testing for this gate was not addressed.
Performance test for this gate was not conducted.
Related GitHub Issues:
Fixes #740.