Create a base LKokkos new device API backend. #810

LuisAlfredoNu · 2024-07-22T20:54:45Z

Before submitting

Please complete the following checklist when submitting a PR:

All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.
Ensure that the test suite passes, by running make test.
Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.
Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
Following the design of Lightning Qubit uses the New Device API end to end, we can now migrate lightning.kokkos device to the new device API.

Description of the Change:
Migration of Lightning Kokkos to integrate the New device API. The list of main features changes are

Add the state_vector, measurements, and adjoint-jacobian classes for lightning.kokkos
Add the simulate, jacobian, simulate_and_jacobian, vjp, and simulate_and_vjp methods to lighting.kokkos
Update unit/integration tests for the new device API to work with lightning.kokkos
Check the full support for sampling in full parity with Lightning Qubit
Replace the old device API for Lightning Kokkos.

Benefits:
Full integration of Lightning kokkos with the new device API.

Possible Drawbacks:

Related GitHub Issues:

[sc-59207], [sc-68825]

…p and simulate_and_vjp

…ne-lightning into kokkosNewAPI_backend

codecov · 2024-07-22T21:08:54Z

Codecov Report

Attention: Patch coverage is 26.73267% with 444 lines in your changes missing coverage. Please review.

Project coverage is 74.67%. Comparing base (cc2942e) to head (5561277).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...ane_lightning/lightning_kokkos/lightning_kokkos.py	31.57%	130 Missing ⚠️
...nylane_lightning/lightning_kokkos/_measurements.py	20.38%	125 Missing ⚠️
...nylane_lightning/lightning_kokkos/_state_vector.py	28.26%	99 Missing ⚠️
...ne_lightning/lightning_kokkos/_adjoint_jacobian.py	25.00%	90 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (cc2942e) and HEAD (5561277). Click for more details.

HEAD has 32 uploads less than BASE

Flag BASE (cc2942e) HEAD (5561277)

40 8

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #810       +/-   ##
===========================================
- Coverage   97.84%   74.67%   -23.17%     
===========================================
  Files         117       20       -97     
  Lines       18658     2330    -16328     
===========================================
- Hits        18255     1740    -16515     
- Misses        403      590      +187

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ld API

multiphaseCFD · 2024-07-23T13:06:15Z

Thanks @LuisAlfredoNu ! Would you like to add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR?

pennylane_lightning/lightning_kokkos/lightning_kokkos.py

vincentmr

LGTM, thanks @LuisAlfredoNu . Not much to complain about at the moment. I'm adding the label "do not merge" to the PR since the description says this will be merged last. But feel free to add/remove whatever label you would like.

pennylane_lightning/lightning_kokkos/lightning_kokkos.py

AmintorDusko

I made some suggestions. I think it is better if you really keep the implementation here minimal. I think you left a lot of code that will probably need to be changed. Please, comment out all code that is not strictly necessary, and pass all tests.

pennylane_lightning/lightning_kokkos/_state_vector.py

pennylane_lightning/lightning_kokkos/lightning_kokkos.py

Co-authored-by: Amintor Dusko <[email protected]>

tests/lightning_qubit/test_measurements_class.py

AmintorDusko

Super nice job! Thank you for that, @LuisAlfredoNu!

.github/workflows/tests_lkcpu_python.yml

tests/lightning_qubit/test_jacobian_method.py

tests/lightning_qubit/test_state_vector_class.py

maliasadi

Great work! 🥳 Feel free to merge it after #884.

.github/CHANGELOG.md

Co-authored-by: Ali Asadi <[email protected]>

Please complete the following checklist when submitting a PR: - [X] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [X] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [X] Ensure that the test suite passes, by running `make test`. - [X] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [X] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** Following the design of *Lightning Qubit* uses the New Device API end to end, we can now migrate `lightning.kokkos` device to the new device API. **Description of the Change:** Migration of Lightning Kokkos to integrate the New device API. The list of main features changes are - Add the `state_vector`, `measurements`, and `adjoint-jacobian` classes for `lightning.kokkos` - Add the `simulate`, `jacobian`, `simulate_and_jacobian`, `vjp`, and `simulate_and_vjp` `methods to lighting.kokkos` - Update unit/integration tests for the new device API to work with `lightning.kokkos` - Check the full support for sampling in full parity with Lightning Qubit - Replace the old device API for Lightning Kokkos. **Benefits:** Full integration of **Lightning kokkos** with the new device API. **Possible Drawbacks:** **Related GitHub Issues:** [sc-59207], [sc-68825] --------- Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Amintor Dusko <[email protected]> Co-authored-by: Vincent Michaud-Rioux <[email protected]> Co-authored-by: Ali Asadi <[email protected]>

### Before submitting Please complete the following checklist when submitting a PR: - [X] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [X] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [X] Ensure that the test suite passes, by running `make test`. - [X] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [X] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** Following the design of *Lightning Qubit* uses the New Device API end to end, we can now migrate `lightning.kokkos` device to the new device API. **Description of the Change:** Migration of Lightning Kokkos to integrate the New device API. The list of main features changes are - Add the `state_vector`, `measurements`, and `adjoint-jacobian` classes for `lightning.kokkos` - Add the `simulate`, `jacobian`, `simulate_and_jacobian`, `vjp`, and `simulate_and_vjp` `methods to lighting.kokkos` - Update unit/integration tests for the new device API to work with `lightning.kokkos` - Check the full support for sampling in full parity with Lightning Qubit - Replace the old device API for Lightning Kokkos. **Benefits:** Full integration of **Lightning kokkos** with the new device API. **Possible Drawbacks:** **Related GitHub Issues:** [sc-59207], [sc-68825] --------- Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Amintor Dusko <[email protected]> Co-authored-by: Vincent Michaud-Rioux <[email protected]> Co-authored-by: Ali Asadi <[email protected]>

LuisAlfredoNu and others added 5 commits July 22, 2024 16:43

Create a base with mock simulate, jacobian, simulate_and_jacobian, vj…

93a52bf

…p and simulate_and_vjp

Auto update version from '0.38.0-dev12' to '0.38.0-dev13'

feca914

Apply format

5ccf20c

Solve issue with measurenment class

bcf961e

Merge branch 'kokkosNewAPI_backend' of github.com:PennyLaneAI/pennyla…

5701cc5

…ne-lightning into kokkosNewAPI_backend

LuisAlfredoNu added 4 commits July 22, 2024 17:29

solve warnings from Pylint

2e4e668

solve warnings from Pylint

3ee9669

Apply format

0e717f6

Skip test native mcm for Kokkos because has a bug with reference to o…

42b6714

…ld API

LuisAlfredoNu marked this pull request as ready for review July 22, 2024 22:21

LuisAlfredoNu added the ci:build_wheels Activate wheel building. label Jul 23, 2024

multiphaseCFD reviewed Jul 23, 2024

View reviewed changes

pennylane_lightning/lightning_kokkos/lightning_kokkos.py Outdated Show resolved Hide resolved

LuisAlfredoNu marked this pull request as draft July 23, 2024 13:18

LuisAlfredoNu added 4 commits July 23, 2024 14:12

Set the base class for LightningDevice and skip the tests

27c7ebc

Apply format

fd02214

apply format

14b4964

Merge branch 'master' into kokkosNewAPI_backend

369ac0e

LuisAlfredoNu marked this pull request as ready for review July 24, 2024 15:07

Auto update version from '0.38.0-dev13' to '0.38.0-dev14'

04283f9

LuisAlfredoNu requested review from multiphaseCFD and a team July 24, 2024 15:08

vincentmr self-requested a review July 24, 2024 18:22

vincentmr added the do not merge Do not merge PR until this label is removed label Jul 24, 2024

vincentmr reviewed Jul 24, 2024

View reviewed changes

pennylane_lightning/lightning_kokkos/lightning_kokkos.py Outdated Show resolved Hide resolved

AmintorDusko previously requested changes Jul 24, 2024

View reviewed changes

LuisAlfredoNu commented Jul 24, 2024

View reviewed changes

pennylane_lightning/lightning_kokkos/lightning_kokkos.py Outdated Show resolved Hide resolved

LuisAlfredoNu and others added 2 commits July 24, 2024 15:26

Apply suggestions from code review

8d40c14

Co-authored-by: Amintor Dusko <[email protected]>

Fix spelling error

44751ee

Co-authored-by: Amintor Dusko <[email protected]>

ringo-but-quantum and others added 2 commits August 23, 2024 21:26

Auto update version from '0.38.0-dev49' to '0.38.0-dev50'

37fdbe2

Fix error of lgpu importError

818093e

LuisAlfredoNu commented Aug 26, 2024

View reviewed changes

tests/lightning_qubit/test_measurements_class.py Show resolved Hide resolved

LuisAlfredoNu commented Aug 26, 2024

View reviewed changes

tests/lightning_qubit/test_measurements_class.py Show resolved Hide resolved

LuisAlfredoNu and others added 12 commits August 26, 2024 09:29

fix ImportError tensor

bd5ebf8

apply format

f64edf0

fix importError in test for lTensor

bef41b6

Auto update version from '0.38.0-dev50' to '0.38.0-dev51'

3e60948

Merge branch 'master' into kokkosNewAPI_backend

4b8b9a7

Auto update version from '0.38.0-dev50' to '0.38.0-dev51'

6e9a6a3

check flaky on CI

2dc1bc8

trigger CIs

7e57ec2

Merge branch 'master' into kokkosNewAPI_backend

ab56233

Auto update version from '0.38.0-dev51' to '0.38.0-dev52'

43b3724

Merge branch 'master' into kokkosNewAPI_backend

00d01c8

Auto update version from '0.38.0-dev53' to '0.38.0-dev54'

4af7af9

AmintorDusko approved these changes Sep 3, 2024

View reviewed changes

.github/workflows/tests_lkcpu_python.yml Outdated Show resolved Hide resolved

tests/lightning_qubit/test_jacobian_method.py Show resolved Hide resolved

tests/lightning_qubit/test_state_vector_class.py Show resolved Hide resolved

maliasadi approved these changes Sep 3, 2024

View reviewed changes

.github/CHANGELOG.md Outdated Show resolved Hide resolved

LuisAlfredoNu and others added 5 commits September 3, 2024 13:23

remove temporary change

47b4860

Update .github/CHANGELOG.md

cf9302b

Co-authored-by: Ali Asadi <[email protected]>

Merge branch 'master' into kokkosNewAPI_backend

f84cdcf

Auto update version from '0.39.0-dev0' to '0.39.0-dev1'

0252f8a

Increase the number of shots for measurenment test

5561277

LuisAlfredoNu removed the do not merge Do not merge PR until this label is removed label Sep 4, 2024

LuisAlfredoNu merged commit 492706a into master Sep 4, 2024
101 of 103 checks passed

LuisAlfredoNu deleted the kokkosNewAPI_backend branch September 4, 2024 14:46

LuisAlfredoNu restored the kokkosNewAPI_backend branch September 4, 2024 15:46

LuisAlfredoNu deleted the kokkosNewAPI_backend branch September 4, 2024 15:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a base LKokkos new device API backend. #810

Create a base LKokkos new device API backend. #810

LuisAlfredoNu commented Jul 22, 2024 •

edited

Loading

codecov bot commented Jul 22, 2024 •

edited

Loading

multiphaseCFD commented Jul 23, 2024

vincentmr left a comment

AmintorDusko left a comment

AmintorDusko left a comment

maliasadi left a comment

Create a base LKokkos new device API backend. #810

Create a base LKokkos new device API backend. #810

Conversation

LuisAlfredoNu commented Jul 22, 2024 • edited Loading

Before submitting

codecov bot commented Jul 22, 2024 • edited Loading

Codecov Report

multiphaseCFD commented Jul 23, 2024

vincentmr left a comment

Choose a reason for hiding this comment

AmintorDusko left a comment

Choose a reason for hiding this comment

AmintorDusko left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

LuisAlfredoNu commented Jul 22, 2024 •

edited

Loading

codecov bot commented Jul 22, 2024 •

edited

Loading