Build and upload LGPU wheels for Linux aarch64 #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #815 +/- ##
===========================================
- Coverage 96.58% 81.80% -14.78%
===========================================
Files 114 17 -97
Lines 19006 1946 -17060
===========================================
- Hits 18357 1592 -16765
+ Misses 649 354 -295 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thanks @maliasadi ! Just leave some comments for the first round.
multiphaseCFD
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Thanks @maliasadi ! LGTM! It's a really nice feature to have
maliasadi
force-pushed
the
add_lgpu_arm_wheel
branch
from
004a045
to
cbdd867
Compare
maliasadi
changed the title
maliasadi
changed the title
mlxd
approved these changes
Aug 20, 2024
maliasadi
force-pushed
the
add_lgpu_arm_wheel
branch
from
8f13a14
to
cfba50d
Compare
multiphaseCFD
pushed a commit
that referenced
this pull request
Sep 8, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [ ] Ensure that the test suite passes, by running `make test`.
- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [ ] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
Add `aarch64` wheels recipes for `"lightning.gpu"`.
**Description of the Change:**
**Benefits:**
Users can pip install LGPU on ARM boxes.
**Possible Drawbacks:**
**Related GitHub Issues:**
[sc-60048]
[sc-60750]
---------
Co-authored-by: ringo-but-quantum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Add
aarch64wheels recipes for"lightning.gpu".Description of the Change:
Benefits:
Users can pip install LGPU on ARM boxes.
Possible Drawbacks:
Related GitHub Issues:
[sc-60048]
[sc-60750]