Update Lightning packaging to follow the PEP 517/518/621/660 standards #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #832 +/- ##
===========================================
- Coverage 97.73% 83.50% -14.23%
===========================================
Files 205 32 -173
Lines 26419 2298 -24121
Branches 608 0 -608
===========================================
- Hits 25820 1919 -23901
+ Misses 599 379 -220 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
…LaneAI/pennylane-lightning into update/Lightning_packaging
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
vincentmr
approved these changes
Aug 12, 2024
AmintorDusko
force-pushed
the
update/Lightning_packaging
branch
from
8079165
to
f9497f2
Compare
mlxd
approved these changes
Aug 12, 2024
multiphaseCFD
pushed a commit
that referenced
this pull request
Aug 13, 2024
#832) **Context:** This PR updates the Lightning Python packaging to the latest standard. This allows us to eliminate pip~=22.0 from requirements*.txt, comply with up-to-date build practices, and fix the inability to build Lightning in place on newer Python environments. **Description of the Change:** Most of the building configuration was moved to the ``pyproject.toml`` file. We kept the ``setup.py`` file working with setuptools in part of the configuration pre-processing. A script with some pre-pre-processing was added to configure the ``pyproject.toml`` file for each backend. **Benefits:** Follow the new standard. Allows the use of more up-to-date pip versions. There will be no impact on the final user, as the installation of the wheels is unaffected by the change in packaging. **Possible Drawbacks:** When building and installing Lightning backends from scratch, we need to run the configuration script. If not the installation will default to ``lightning.qubit``, or the last configuration. **Related GitHub Issues:** [sc-65227] --------- Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Lee James O'Riordan <[email protected]> Co-authored-by: Vincent Michaud-Rioux <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: This PR updates the Lightning Python packaging to the latest standard. This allows us to eliminate pip~=22.0 from requirements*.txt, comply with up-to-date build practices, and fix the inability to build Lightning in place on newer Python environments.
Description of the Change: Most of the building configuration was moved to the
pyproject.tomlfile. We kept thesetup.pyfile working with setuptools in part of the configuration pre-processing. A script with some pre-pre-processing was added to configure thepyproject.tomlfile for each backend.Benefits: Follow the new standard. Allows the use of more up-to-date pip versions. There will be no impact on the final user, as the installation of the wheels is unaffected by the change in packaging.
Possible Drawbacks: When building and installing Lightning backends from scratch, we need to run the configuration script. If not the installation will default to
lightning.qubit, or the last configuration.Related GitHub Issues:
[sc-65227]