Update unit/integration tests for the new device #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## kokkosNewAPI_backend #840 +/- ##
========================================================
+ Coverage 67.08% 73.00% +5.92%
========================================================
Files 20 20
Lines 2297 2297
========================================================
+ Hits 1541 1677 +136
+ Misses 756 620 -136 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Co-authored-by: Vincent Michaud-Rioux <[email protected]>
Co-authored-by: Amintor Dusko <[email protected]>
LuisAlfredoNu
commented
Aug 12, 2024
Comment on lines
+253
to
+254
| pl-device-test --device ${DEVICENAME} --skip-ops --shots=20000 $COVERAGE_FLAGS --cov-append | ||
| pl-device-test --device ${DEVICENAME} --shots=None --skip-ops $COVERAGE_FLAGS --cov-append |
There was a problem hiding this comment.
All the PL base tests now are uncomment for CI with GitHub Actions
LuisAlfredoNu
commented
Aug 12, 2024
| @@ -431,7 +431,7 @@ class LightningKokkos(Device): | |||
| # pylint: disable=too-many-instance-attributes | |||
|
|
|||
| # General device options | |||
| _device_options = ("rng", "c_dtype", "batch_obs") | |||
There was a problem hiding this comment.
Remove numpy random generator from the device option. This is only applicable to MCMC
LuisAlfredoNu
commented
Aug 12, 2024
LuisAlfredoNu
commented
Aug 12, 2024
Comment on lines
+520
to
+521
| # It is necessary to set the mcmc default configuration to complete the requirements of ExecuteConfig | ||
| mcmc_default = {"mcmc": False, "kernel_name": None, "num_burnin": 0, "rng": None} |
There was a problem hiding this comment.
Setting the mcmc default values in a hardcode way to avoid complaints from PL-base and prevent user modify
LuisAlfredoNu
commented
Aug 12, 2024
Comment on lines
-29
to
-31
| if device_name == "lightning.kokkos": | ||
| pytest.skip("Kokkos new API in WIP. Skipping.", allow_module_level=True) | ||
|
|
There was a problem hiding this comment.
All the unit / integration tests now are uncommented to check the functionality of the new device API with Kokkos
Co-authored-by: Amintor Dusko <[email protected]>
AmintorDusko
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Migrate the lightning.kokkos device to the new device API.
Description of the Change:
Unlock and modify all the unit tests for
Lightning Kokkosand pass all the CI.Benefits:
Integration of LighntingKokkos with the new device API.
Possible Drawbacks:
Related GitHub Issues:
Partial / Freezzed PR⚠️ ❄️
To make a smooth integration of LightningKokkos with the new device API, we set the branch
kokkosNewAPI_backendas the base branch target for this development.The branch
kokkosNewAPI_backendhas the mock of all classes and methods necessary for the new API. Also, several tests were disabled withAdditionally, the CI testing from PennyLane for LKokkos is temporally disabled through commenting on the following lines in .github/workflows files
However, these tests will unblocked as the implementation progresses.
After all the developments for integrating LightningKokkos with the new API have been completed then the PR will be open to merging to master
[sc-68823]