Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use decomposition instead of Operator.expand #846

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Conversation

astralcai
Copy link
Contributor

Operator.expand is deprecated (PennyLaneAI/pennylane#5994). Operator.decomposition should be used instead.

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (27813be) to head (c5e1dc2).

❗ There is a different number of reports uploaded between BASE (27813be) and HEAD (c5e1dc2). Click for more details.

HEAD has 32 uploads less than BASE
Flag BASE (27813be) HEAD (c5e1dc2)
40 8
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #846       +/-   ##
===========================================
- Coverage   98.40%   80.99%   -17.42%     
===========================================
  Files         113       17       -96     
  Lines       18413     1936    -16477     
===========================================
- Hits        18120     1568    -16552     
- Misses        293      368       +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @astralcai! Feel free to ping me again when you add the PR to ./.github/CHANGELOG.md.

pennylane_lightning/core/_serialize.py Show resolved Hide resolved
.github/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, @astralcai!

@astralcai astralcai merged commit d6f681d into master Aug 12, 2024
74 of 75 checks passed
@astralcai astralcai deleted the op-expand-dep branch August 12, 2024 19:12
multiphaseCFD pushed a commit that referenced this pull request Aug 13, 2024
`Operator.expand` is deprecated
(PennyLaneAI/pennylane#5994).
`Operator.decomposition` should be used instead.

---------

Co-authored-by: ringo-but-quantum <[email protected]>
Co-authored-by: Ali Asadi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants