-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable CI for draft PRs #847
Conversation
Hello. You may have forgotten to update the changelog!
|
Can we have a label that could re-enable CIs for draft PRs? |
This was a long-time coming request. We can enable the CI by going out of draft mode. |
…nnyLaneAI/pennylane-lightning into disable-ci-for-pl-lightning-draft-prs
…nnyLaneAI/pennylane-lightning into disable-ci-for-pl-lightning-draft-prs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #847 +/- ##
==========================================
+ Coverage 97.59% 98.34% +0.75%
==========================================
Files 117 151 +34
Lines 18642 23636 +4994
==========================================
+ Hits 18193 23244 +5051
+ Misses 449 392 -57 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there might be a couple of cases where we need careful about operator precedence but otherwise this looks good. 👍
Reran CI in "draft" and "ready for review" after adding @Mandrenkov suggestions on operator ordering, all works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anthayes92, just want to confirm the new if
conditions work correctly with push
and workflow_call
events before approving!
…nnyLaneAI/pennylane-lightning into disable-ci-for-pl-lightning-draft-prs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a style suggestion, but looks good to me. Thanks @anthayes92 !
Hey @anthayes92 |
Similar reason as mentioned here, though since you have a higher stake in the lightning repo perhaps you'd like to make the call? |
Let's go ahead and merge this one and also the PennyLane PR (PennyLaneAI/pennylane#6093). We can add a label to run tests in draft mode in a follow-up PR. |
**Context:** Tooling Team has requested that all CI checks for draft PRs across all PennyLane repos are to be disabled to free up GH runner resources. [SC Story](https://app.shortcut.com/xanaduai/story/66346/disable-ci-for-pl-draft-prs). **Description of the Change:** Conditions for checking whether a PR is in draft state have been added to existing workflows. **Benefits:** Reduces GH runner usage. **Possible Drawbacks:** Some development steps are deferred to PRs in "ready for review" state only. **Related GitHub Issues:** N/A ### Verification: Created this PR as draft, only lightweight CI checks use GitHub runners (formatting, changelog reminder). When marked as "ready for review" the CI checks ran (excluding wheel builds and multi-gpu runners). When labels added for wheel builds and multi-gpu runners all CI checks ran. ![Screenshot from 2024-08-12 15-26-32](https://github.com/user-attachments/assets/e78c24f8-8f31-46a0-91f6-eb2d1802694b) --------- Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Lee James O'Riordan <[email protected]>
Context:
Tooling Team has requested that all CI checks for draft PRs across all PennyLane repos are to be disabled to free up GH runner resources. SC Story.
Description of the Change:
Conditions for checking whether a PR is in draft state have been added to existing workflows.
Benefits:
Reduces GH runner usage.
Possible Drawbacks:
Some development steps are deferred to PRs in "ready for review" state only.
Related GitHub Issues:
N/A
Verification:
Created this PR as draft, only lightweight CI checks use GitHub runners (formatting, changelog reminder). When marked as "ready for review" the CI checks ran (excluding wheel builds and multi-gpu runners). When labels added for wheel builds and multi-gpu runners all CI checks ran.