Add `stateprep` support to `lightning.tensor` - MPS #849

multiphaseCFD · 2024-08-13T11:39:10Z

Before submitting

Please complete the following checklist when submitting a PR:

All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.
Ensure that the test suite passes, by running make test.
Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.
Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:

Add qml.StatePrep() and qml.QubitStateVector() support to lightning.tensor. Note that svd decomposition is conduct by numpy in the python layer based on the fact that svd operation with numpy on cpu is faster than cutensornet on A100 GPU if the bond dimension is less than 256. For more info, please visit here.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

### Before submitting Please complete the following checklist when submitting a PR: - [ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [ ] Ensure that the test suite passes, by running `make test`. - [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [x] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** Add GPU device compute capability check. L-Tensor has device compute capability check like L-GPU now. [SC-69118] **Description of the Change:** **Benefits:** Error will be raised when running `lightning.tensor` on a unsupported GPU. **Possible Drawbacks:** **Related GitHub Issues:** #799 --------- Co-authored-by: ringo-but-quantum <[email protected]>

vincentmr

Second round, cheers!

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/MPSTNCuda.hpp

...ane_lightning/core/src/simulators/lightning_tensor/tncuda/bindings/LTensorTNCudaBindings.hpp

pennylane_lightning/lightning_tensor/lightning_tensor.py

vincentmr

LGMT, thanks @multiphaseCFD :)

maliasadi

Thanks @multiphaseCFD! Just a few minor suggestions, but happy to get it merged soon

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/MPSTNCuda.hpp

...ane_lightning/core/src/simulators/lightning_tensor/tncuda/bindings/LTensorTNCudaBindings.hpp

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/tests/Tests_MPSTNCuda.cpp

pennylane_lightning/lightning_tensor/_tensornet.py

...ane_lightning/core/src/simulators/lightning_tensor/tncuda/bindings/LTensorTNCudaBindings.hpp

maliasadi

🚀

Please complete the following checklist when submitting a PR: - [ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [ ] Ensure that the test suite passes, by running `make test`. - [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [ ] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: ringo-but-quantum <[email protected]>

### Before submitting Please complete the following checklist when submitting a PR: - [x] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [ ] Ensure that the test suite passes, by running `make test`. - [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [x] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** [SC-71278] Add `qml.StatePrep()` and `qml.QubitStateVector()` support to `lightning.tensor`. Note that `svd` decomposition is conduct by `numpy` in the python layer based on the fact that `svd` operation with `numpy` on cpu is faster than `cutensornet` on `A100` GPU if the `bond dimension` is less than `256`. For more info, please visit [here](https://developer.nvidia.com/cuquantum-sdk). **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: ringo-but-quantum <[email protected]> Co-authored-by: Vincent Michaud-Rioux <[email protected]> Co-authored-by: Ali Asadi <[email protected]> Co-authored-by: Lee James O'Riordan <[email protected]> Co-authored-by: Josh Izaac <[email protected]> Co-authored-by: Lee J. O'Riordan <[email protected]> Co-authored-by: Pietropaolo Frisoni <[email protected]> Co-authored-by: erick-xanadu <[email protected]> Co-authored-by: Astral Cai <[email protected]> Co-authored-by: Amintor Dusko <[email protected]> Co-authored-by: Shiro-Raven <[email protected]> Co-authored-by: albi3ro <[email protected]>

multiphaseCFD and others added 30 commits July 17, 2024 18:22

Auto update version from '0.38.0-dev10' to '0.38.0-dev11'

6da1e25

Merge branch 'master' into add_var_tensornet

9046199

Auto update version from '0.38.0-dev11' to '0.38.0-dev12'

3877ebf

make format

1b12733

add more complex Hermitian matrix

afa67c9

add python and pybind layer

49e529f

add more py unit tests

e97107e

add more unit tests

85a9bd5

add changelog

93ff20f

tidy up C++

fa2c8fb

further clean C++ layer

0cdc3d0

switch on more python unit tests

fca24d3

tidy up python layer

19dbedc

tidy up linaralg and add more unit tests

2737df1

Add var support to multi-terms Hamiltionian

976da4d

tidy up code

ad8d9bd

Auto update version from '0.38.0-dev12' to '0.38.0-dev13'

3ac6211

remove square_matrix_cuda_device

255e341

further tidy up

7b44e8a

fix typo

00beafa

initial commit

48f74b5

Merge branch 'master' into add_var_tensornet

cdb4606

quick fix

6afbc37

Auto update version from '0.38.0-dev12' to '0.38.0-dev13'

8a588e6

add more docstrings

2103fa0

typo fix

bb85c54

add more unit tests

20113a0

Auto update version from '0.38.0-dev13' to '0.38.0-dev18'

3f24ca2

initial commit

646e2e1

Base automatically changed from add_probs_ltensor to master August 21, 2024 14:13

multiphaseCFD and others added 3 commits August 21, 2024 10:16

Merge branch 'master' into add_stateprep_ltensor

fa1d08b

Auto update version from '0.38.0-dev40' to '0.38.0-dev41'

6308d6d

fix codefactor complains

2de2f26

vincentmr reviewed Aug 21, 2024

View reviewed changes

apply Vincent's comments

285e1c9

multiphaseCFD requested a review from vincentmr August 21, 2024 17:28

vincentmr approved these changes Aug 21, 2024

View reviewed changes

Merge branch 'master' into add_stateprep_ltensor

ff01e3e

multiphaseCFD requested review from maliasadi and removed request for maliasadi August 21, 2024 19:29

maliasadi reviewed Aug 21, 2024

View reviewed changes

multiphaseCFD and others added 3 commits August 21, 2024 20:08

apply Ali's comments

6a92681

Auto update version from '0.38.0-dev41' to '0.38.0-dev42'

0275d68

pre-allocate Ms

4d5b690

multiphaseCFD requested a review from maliasadi August 21, 2024 20:19

maliasadi approved these changes Aug 21, 2024

View reviewed changes

multiphaseCFD and others added 10 commits August 21, 2024 21:22

Trigger CIs

1be48eb

add essential headers to unit tests

96e65b2

Auto update version from '0.38.0-dev42' to '0.38.0-dev43'

07ef802

Auto update version from '0.38.0-dev42' to '0.38.0-dev43'

be3fd9c

Merge branch 'master' into add_stateprep_ltensor

3c94a01

Auto update version from '0.38.0-dev42' to '0.38.0-dev43'

737ca5b

fix typo

8ce797b

Merge branch 'master' into add_stateprep_ltensor

8d7011e

Auto update version from '0.38.0-dev43' to '0.38.0-dev44'

86c1b82

multiphaseCFD merged commit ee837d6 into master Aug 22, 2024
110 of 111 checks passed

multiphaseCFD deleted the add_stateprep_ltensor branch August 22, 2024 21:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `stateprep` support to `lightning.tensor` - MPS #849

Add `stateprep` support to `lightning.tensor` - MPS #849

multiphaseCFD commented Aug 13, 2024 •

edited

Loading

vincentmr left a comment

vincentmr left a comment

maliasadi left a comment

maliasadi left a comment

Add stateprep support to lightning.tensor - MPS #849

Add stateprep support to lightning.tensor - MPS #849

Conversation

multiphaseCFD commented Aug 13, 2024 • edited Loading

Before submitting

vincentmr left a comment

Choose a reason for hiding this comment

vincentmr left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

Add `stateprep` support to `lightning.tensor` - MPS #849

Add `stateprep` support to `lightning.tensor` - MPS #849

multiphaseCFD commented Aug 13, 2024 •

edited

Loading