Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/lightning tests #850

Merged
merged 34 commits into from
Aug 14, 2024
Merged

Fix/lightning tests #850

merged 34 commits into from
Aug 14, 2024

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Aug 13, 2024

Fixing Lightning tests in the Plugin-Test-Matrix

Context: Tests were falling. After changes, they are passing:
stable/stable
stable/latest
Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-71386]

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.27%. Comparing base (c6b86a5) to head (bb560c0).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c6b86a5) and HEAD (bb560c0). Click for more details.

HEAD has 20 uploads less than BASE
Flag BASE (c6b86a5) HEAD (bb560c0)
25 5
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #850       +/-   ##
===========================================
- Coverage   97.85%   51.27%   -46.58%     
===========================================
  Files         113       17       -96     
  Lines       18160     1915    -16245     
===========================================
- Hits        17770      982    -16788     
- Misses        390      933      +543     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmintorDusko AmintorDusko added the ci:build_wheels Activate wheel building. label Aug 14, 2024
@AmintorDusko AmintorDusko marked this pull request as ready for review August 14, 2024 16:52
@vincentmr vincentmr self-requested a review August 14, 2024 17:19
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, but otherwise looks good to me @AmintorDusko . Feel free to resolve and merge.

.github/workflows/tests_lgpumpi_python.yml Outdated Show resolved Hide resolved
@AmintorDusko AmintorDusko requested a review from a team August 14, 2024 17:32
.github/workflows/tests_lgpu_python.yml Outdated Show resolved Hide resolved
.github/workflows/tests_lgpumpi_python.yml Show resolved Hide resolved
.github/workflows/tests_lgpumpi_python.yml Outdated Show resolved Hide resolved
.github/workflows/tests_without_binary.yml Outdated Show resolved Hide resolved
.github/workflows/tests_lqcpu_python.yml Show resolved Hide resolved
.github/workflows/tests_lqcpu_python.yml Outdated Show resolved Hide resolved
.github/workflows/tests_lkcpu_python.yml Show resolved Hide resolved
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AmintorDusko! Please add the SC ticket to the PR, looks good to me otherwise 🥳

@AmintorDusko AmintorDusko merged commit 8e85fce into master Aug 14, 2024
95 of 96 checks passed
@AmintorDusko AmintorDusko deleted the Fix/Lightning_Tests branch August 14, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants