Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fix/lightning tests #854

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Fix/fix/lightning tests #854

merged 3 commits into from
Aug 15, 2024

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Aug 15, 2024


Context: Calling setup.py is not supposed to have -m.

Description of the Change: removing wrong -m.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-71443]

@AmintorDusko AmintorDusko added the ci:build_wheels Activate wheel building. label Aug 15, 2024
@AmintorDusko AmintorDusko marked this pull request as ready for review August 15, 2024 13:08
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @AmintorDusko .

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.75%. Comparing base (8e85fce) to head (d1f6730).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8e85fce) and HEAD (d1f6730). Click for more details.

HEAD has 15 uploads less than BASE
Flag BASE (8e85fce) HEAD (d1f6730)
34 19
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #854       +/-   ##
===========================================
- Coverage   97.64%   80.75%   -16.90%     
===========================================
  Files          84       17       -67     
  Lines       11349     2421     -8928     
===========================================
- Hits        11082     1955     -9127     
- Misses        267      466      +199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AmintorDusko AmintorDusko merged commit ec9e340 into master Aug 15, 2024
140 of 146 checks passed
@AmintorDusko AmintorDusko deleted the Fix/Fix/Lightning_tests branch August 15, 2024 13:35
@AmintorDusko
Copy link
Contributor Author

@mudit2812, this might fix the most recent stable-related problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants