Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build LTensor wheels on Linux x86_64 and aarch64 #862

Merged
merged 19 commits into from
Sep 10, 2024
Merged

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Aug 21, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-71867]
[sc-70914]

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.06%. Comparing base (cc36544) to head (fe352ae).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (cc36544) and HEAD (fe352ae). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (cc36544) HEAD (fe352ae)
8 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #862       +/-   ##
===========================================
- Coverage   94.69%   59.06%   -35.64%     
===========================================
  Files         192       24      -168     
  Lines       25609     2162    -23447     
===========================================
- Hits        24251     1277    -22974     
+ Misses       1358      885      -473     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr added this to the v0.38.0 milestone Aug 23, 2024
@maliasadi maliasadi removed this from the v0.38.0 milestone Aug 26, 2024
@maliasadi maliasadi marked this pull request as ready for review September 6, 2024 14:22
@maliasadi maliasadi added urgent Mark a pull request as high priority and removed urgent Mark a pull request as high priority labels Sep 9, 2024
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work @maliasadi !

bin/auditwheel Show resolved Hide resolved
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @maliasadi .

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks @maliasadi !

@maliasadi maliasadi merged commit 37d9715 into master Sep 10, 2024
67 of 76 checks passed
@maliasadi maliasadi deleted the add_lt_wheels branch September 10, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants