Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate wheels artifacts to v4 #893

Merged
merged 13 commits into from
Sep 9, 2024
Merged

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Sep 6, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
As a followup to #887, this PR fixes the issue with the name of wheels artifacts as per actions/upload-artifact#478

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-73124]

@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (70dfdf7) to head (fe9968c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
- Coverage   96.25%   95.79%   -0.47%     
==========================================
  Files         212      191      -21     
  Lines       28020    25446    -2574     
==========================================
- Hits        26972    24376    -2596     
- Misses       1048     1070      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliasadi maliasadi removed the ci:build_wheels Activate wheel building. label Sep 6, 2024
.github/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

.github/workflows/wheel_linux_x86_64.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @maliasadi Just one comment

.github/workflows/wheel_linux_aarch64.yml Outdated Show resolved Hide resolved
@maliasadi maliasadi added the urgent Mark a pull request as high priority label Sep 6, 2024
@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Sep 9, 2024
@maliasadi maliasadi merged commit 7943928 into master Sep 9, 2024
99 of 100 checks passed
@maliasadi maliasadi deleted the fix_wheels_upload_artifact_v4 branch September 9, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants