Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent labels from triggering CI #899

Merged
merged 14 commits into from
Sep 10, 2024
Merged

Conversation

anthayes92
Copy link
Contributor

@anthayes92 anthayes92 commented Sep 9, 2024

Context:
CI is being triggered by adding any label to a PR in "ready for review" state. This fixes that undesired behaviour

Description of the Change:
Removes the labeled PR type from workflows.

Benefits:
Prevents unnecessary resource usage.

Possible Drawbacks:
When labels are added that intend to affect CI, a followup commit must be made to trigger the CI

Related GitHub Issues:

Verification:

Added various labels to this PR in a "ready for review" state, no CI checks were triggered as a result.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@anthayes92 anthayes92 marked this pull request as ready for review September 9, 2024 14:50
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.88%. Comparing base (43374cc) to head (dcf2721).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
+ Coverage   96.22%   97.88%   +1.66%     
==========================================
  Files         212      212              
  Lines       28187    28187              
==========================================
+ Hits        27123    27591     +468     
+ Misses       1064      596     -468     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmintorDusko
Copy link
Contributor

Hey @anthayes92, I just merged master to your PR.

@anthayes92 anthayes92 added do not merge Do not merge PR until this label is removed bug-fix Indicates this fixes a known bug ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request and removed do not merge Do not merge PR until this label is removed bug-fix Indicates this fixes a known bug ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request labels Sep 9, 2024
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all I needed to see:
image
Thank you, @anthayes92!

@AmintorDusko AmintorDusko requested a review from a team September 9, 2024 19:18
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but don't forget to update the CHANGELOG.

@anthayes92
Copy link
Contributor Author

but don't forget to update the CHANGELOG.

Appreciate the reminder, though we typically haven't been adding these GH workflow updates to the changelog since the application code is unchanged

@anthayes92 anthayes92 merged commit ee561f6 into master Sep 10, 2024
104 checks passed
@anthayes92 anthayes92 deleted the prevent-labels-triggering-ci branch September 10, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants