-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent labels from triggering CI #899
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 96.22% 97.88% +1.66%
==========================================
Files 212 212
Lines 28187 28187
==========================================
+ Hits 27123 27591 +468
+ Misses 1064 596 -468 ☔ View full report in Codecov by Sentry. |
Hey @anthayes92, I just merged master to your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all I needed to see:
Thank you, @anthayes92!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but don't forget to update the CHANGELOG.
Appreciate the reminder, though we typically haven't been adding these GH workflow updates to the changelog since the application code is unchanged |
Context:
CI is being triggered by adding any label to a PR in "ready for review" state. This fixes that undesired behaviour
Description of the Change:
Removes the
labeled
PR type from workflows.Benefits:
Prevents unnecessary resource usage.
Possible Drawbacks:
When labels are added that intend to affect CI, a followup commit must be made to trigger the CI
Related GitHub Issues:
Verification:
Added various labels to this PR in a "ready for review" state, no CI checks were triggered as a result.