Update ecosystem build tooling #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to upstream dependency on PennyLane, we can await the NP2.0 migration to complete before proceeding with this PR. CI will currently indicate any breakage with 1.x numpy support |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #901 +/- ##
===========================================
- Coverage 96.24% 83.03% -13.22%
===========================================
Files 212 24 -188
Lines 28102 2169 -25933
===========================================
- Hits 27047 1801 -25246
+ Misses 1055 368 -687 ☔ View full report in Codecov by Sentry. |
mlxd
changed the title
AmintorDusko
approved these changes
Sep 10, 2024
maliasadi
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: Update Pybind11 to the latest release (2.13.5) for enabling Numpy 2.0 support, amongst other fixes. In addition, an upgrade to CIBW is required, as well as a new minimum version for MacOS support to 12.0
Description of the Change: Pybind11 updated to v2.13.5. CiBuildWheel updated to 2.20. MacOS wheel builds updated to a minimum support of 12.0. Allow import failure to return as warning for debugging.
Benefits:
Possible Drawbacks:
Related GitHub Issues: