Add the support class for the Adjoint Jacobian to the new device #907

LuisAlfredoNu · 2024-09-11T21:34:24Z

Before submitting

Please complete the following checklist when submitting a PR:

All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.
Ensure that the test suite passes, by running make test.
Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.
Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
Migrate LightningGPU to the new device API

Description of the Change:
Create the adjoint-jacobian class for the new device API to achieve the jacobian and vjp methods

Benefits:
Unlocking the adjoint-jacobian capabilities with the new device API for LGPU

Possible Drawbacks:

Related GitHub Issues:

Freezzed PR ⚠️ ❄️

To make a smooth integration of LightningGPU with the new device API, we set the branch gpuNewAPI_backend as the base branch target for future developments related to this big task.

The branch gpuNewAPI_backend has the mock of all classes and methods necessary for the new API. Also, several tests were disabled with

if device_name == "lightning.gpu":
    pytest.skip("LGPU new API in WIP.  Skipping.",allow_module_level=True)

However, these tests will unblocked as the implementation progresses.

After all the developments for integrating LightningGPU with the new API have been completed then the PR will be open to merge to master

[sc-70936] [sc-70939]

github-actions · 2024-09-11T21:34:41Z

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

A one-to-two sentence description of the change. You may include a small working example for new features.
A link back to this PR.
Your name (or GitHub username) in the contributors section.

Co-authored-by: Vincent Michaud-Rioux <[email protected]>

…-lightning into gpuNewAPI_simulate

Co-authored-by: Ali Asadi <[email protected]>

codecov · 2024-09-16T23:01:27Z

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (gpuNewAPI_backend@fdc3f32). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...ylane_lightning/lightning_gpu/_adjoint_jacobian.py	96.96%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                  @@
##             gpuNewAPI_backend     #907   +/-   ##
====================================================
  Coverage                     ?   76.06%           
====================================================
  Files                        ?       28           
  Lines                        ?     2202           
  Branches                     ?        0           
====================================================
  Hits                         ?     1675           
  Misses                       ?      527           
  Partials                     ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AmintorDusko · 2024-09-17T12:53:50Z

Hey @LuisAlfredoNu, is this PR ready for review? Apparently, we have several test fails.

LuisAlfredoNu · 2024-09-17T13:11:44Z

Hey @LuisAlfredoNu, is this PR ready for review? Apparently, we have several test fails.

@AmintorDusko
Sorry, I realize that right now it has several errors after the merge of the last commit of simulate branch 😞. I will fix it and call to review it again. 😄

AmintorDusko · 2024-09-17T13:22:22Z

Hey @LuisAlfredoNu, is this PR ready for review? Apparently, we have several test fails.

@AmintorDusko Sorry, I realize that right now it has several errors after the merge of the last commit of simulate branch 😞. I will fix it and call to review it again. 😄

Thank you, @LuisAlfredoNu!

LuisAlfredoNu · 2024-09-17T14:54:09Z

pennylane_lightning/lightning_kokkos/lightning_kokkos.py

@@ -302,7 +302,6 @@ def __init__(  # pylint: disable=too-many-arguments
        shots=None,
        batch_obs=False,
        # Kokkos arguments
-        sync=True,


The var sync is no longer needed in LK.

LuisAlfredoNu · 2024-09-17T14:55:25Z

pennylane_lightning/lightning_kokkos/_state_vector.py

    ):  # pylint: disable=too-many-arguments

        super().__init__(num_wires, dtype)

        self._device_name = "lightning.kokkos"

        self._kokkos_config = {}
-        self._sync = sync


In LK, any method requires the var sync

maliasadi

Nice work! Thanks @LuisAlfredoNu! Happy to approve 💯

maliasadi · 2024-09-17T18:48:59Z

pennylane_lightning/lightning_gpu/_adjoint_jacobian.py

-import pennylane as qml
+from pennylane.tape import QuantumTape


AmintorDusko

Great job!

LuisAlfredoNu added 21 commits September 4, 2024 17:51

include the new device base class

120bbed

add measurements

bdf4daa

State vector almos done

b05a6a4

tmp commit

5dac907

Solve prop issue

bfd0771

ready measurenment class for LGPU

a1ff6c6

print helps for measurements

a0cfb1d

Merge gpuNewAPI_simulate

f472471

grammar correction

c7ac82d

cleaning code

6627913

apply format

6290953

delete usuless variables

219262b

delete prints

bca1a74

Revert change in measurenment test

0f8f957

Merge branch 'gpuNewAPI_backend' into gpuNewAPI_simulate

a9ccf62

Merge branch 'gpuNewAPI_backend' into gpuNewAPI_simulate

a99b6e8

add simulate method

0399f18

apply format

23d5696

Shuli suggestion

585c313

apply format

5eee8eb

Develop Jacobian

be3c6f7

unlock the test for jacobian and adjoint-jacobian

7ff13b3

LuisAlfredoNu added the urgent Mark a pull request as high priority label Sep 11, 2024

LuisAlfredoNu and others added 6 commits September 11, 2024 21:52

apply format

3cec8b1

Update pennylane_lightning/lightning_gpu/_mpi_handler.py

92089eb

Co-authored-by: Vincent Michaud-Rioux <[email protected]>

Apply suggestions from code review Vinvent's comments

196042a

Co-authored-by: Vincent Michaud-Rioux <[email protected]>

Vincent's comments

b4ed1ae

Merge branch 'gpuNewAPI_simulate' of github.com:PennyLaneAI/pennylane…

695283b

…-lightning into gpuNewAPI_simulate

apply format

1729d06

LuisAlfredoNu and others added 11 commits September 16, 2024 19:26

apply_basis_state as abstract in GPU

54afeb5

apply format

ac87663

Apply suggestions from code review Ali suggestion docs

35270fb

Co-authored-by: Ali Asadi <[email protected]>

propagate namming suggestion

f51cbb9

Merge branch 'gpuNewAPI_simulate' into gpuNewAPI_AdjJaco

29675e7

Apply suggestions from code review. Ali's suggestion 3

65e66e9

Co-authored-by: Ali Asadi <[email protected]>

solve errors with kokkos

0472fdd

apply format

96728cb

Merge branch 'gpuNewAPI_simulate' into gpuNewAPI_AdjJaco

5901a64

solve conflicts

112ead0

Merge branch 'gpuNewAPI_backend' into gpuNewAPI_AdjJaco

1acf4db

LuisAlfredoNu marked this pull request as ready for review September 16, 2024 22:57

apply format

87778d6

LuisAlfredoNu requested a review from a team September 16, 2024 22:58

solve issue with reset

c493d47

solve error with kokkos

faead9c

LuisAlfredoNu commented Sep 17, 2024

View reviewed changes

LuisAlfredoNu requested review from maliasadi, multiphaseCFD and AmintorDusko September 17, 2024 15:53

maliasadi approved these changes Sep 17, 2024

View reviewed changes

AmintorDusko approved these changes Sep 17, 2024

View reviewed changes

LuisAlfredoNu merged commit a7c4b09 into gpuNewAPI_backend Sep 17, 2024
75 checks passed

LuisAlfredoNu deleted the gpuNewAPI_AdjJaco branch September 17, 2024 19:08

LuisAlfredoNu restored the gpuNewAPI_AdjJaco branch September 17, 2024 19:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the support class for the Adjoint Jacobian to the new device #907

Add the support class for the Adjoint Jacobian to the new device #907

LuisAlfredoNu commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024

codecov bot commented Sep 16, 2024 •

edited

Loading

AmintorDusko commented Sep 17, 2024

LuisAlfredoNu commented Sep 17, 2024

AmintorDusko commented Sep 17, 2024

LuisAlfredoNu Sep 17, 2024

LuisAlfredoNu Sep 17, 2024

maliasadi left a comment

maliasadi Sep 17, 2024

AmintorDusko left a comment

		import pennylane as qml
		from pennylane.tape import QuantumTape

Add the support class for the Adjoint Jacobian to the new device #907

Add the support class for the Adjoint Jacobian to the new device #907

Conversation

LuisAlfredoNu commented Sep 11, 2024 • edited Loading

Before submitting

Freezzed PR ⚠️ ❄️

github-actions bot commented Sep 11, 2024

codecov bot commented Sep 16, 2024 • edited Loading

Codecov Report

AmintorDusko commented Sep 17, 2024

LuisAlfredoNu commented Sep 17, 2024

AmintorDusko commented Sep 17, 2024

LuisAlfredoNu Sep 17, 2024

Choose a reason for hiding this comment

LuisAlfredoNu Sep 17, 2024

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

maliasadi Sep 17, 2024

Choose a reason for hiding this comment

AmintorDusko left a comment

Choose a reason for hiding this comment

LuisAlfredoNu commented Sep 11, 2024 •

edited

Loading

codecov bot commented Sep 16, 2024 •

edited

Loading