-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge lightning.gpu and lightning.tensor test CIs and add control by a label #911
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #911 +/- ##
==========================================
+ Coverage 96.22% 96.32% +0.10%
==========================================
Files 214 94 -120
Lines 29804 11793 -18011
==========================================
- Hits 28679 11360 -17319
+ Misses 1125 433 -692 ☔ View full report in Codecov by Sentry. |
Last commit (1b264c4) shows an example of GPU runners not being activated without the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @AmintorDusko . Just one question: is there a plan to move lightning.kokkos-cuda tests to tests_gpu
workflows?
Maybe in the future. This one requires more time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @AmintorDusko for the nice work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AmintorDusko!
…Is path selection; Co-authored-by: maliasadi
…lane-lightning into update/GPU-CIs
Hi @maliasadi, I updated the workflows as discussed offline and following your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AmintorDusko! Just a few questions to ensure the compatibility of the support with pennylane-plugin-matrix and on push-to-master.. happy to approve soon 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AmintorDusko! LGTM 🎉
Context: Merge lightning.gpu and lightning.tensor test CIs and add control by a label
Description of the Change: Merge
lightning.gpu
andlightning.tensor
GPU tests in single Python and C++ CIs controlled by theci:use-gpu-runner
label.Benefits: Efficient CIs, faster queue, and code reduction.
Possible Drawbacks:
[sc-73818]
Related GitHub Issues: