Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch tests after deprecation #920

Merged
merged 13 commits into from
Sep 24, 2024
Merged

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Sep 20, 2024

Context:
Patching stable lightning tests for the latest pennylane.

stable/latest

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.65%. Comparing base (8a0d3ed) to head (c89f8a5).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8a0d3ed) and HEAD (c89f8a5). Click for more details.

HEAD has 56 uploads less than BASE
Flag BASE (8a0d3ed) HEAD (c89f8a5)
79 23
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
- Coverage   94.95%   85.65%   -9.31%     
==========================================
  Files          95       24      -71     
  Lines       13150     3479    -9671     
==========================================
- Hits        12487     2980    -9507     
+ Misses        663      499     -164     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmintorDusko AmintorDusko marked this pull request as ready for review September 20, 2024 20:27
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AmintorDusko! 🦅

.github/workflows/tests_lqcpu_python.yml Outdated Show resolved Hide resolved
.github/workflows/tests_lqcpu_python.yml Outdated Show resolved Hide resolved
.github/workflows/tests_lqcpu_python.yml Outdated Show resolved Hide resolved
.github/workflows/tests_lqcpu_python.yml Outdated Show resolved Hide resolved
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @AmintorDusko .

@maliasadi maliasadi added ci:build_wheels Activate wheel building. urgent Mark a pull request as high priority and removed ci:build_wheels Activate wheel building. labels Sep 23, 2024
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🙌

@AmintorDusko AmintorDusko merged commit c607b6c into master Sep 24, 2024
176 of 177 checks passed
@AmintorDusko AmintorDusko deleted the patch_tests_after_deprecation branch September 24, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants