[WIP] Catalyst support for qml.CosineWindow
#929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 1, 2024
willjmax
changed the title
qml.CosineWindow
maliasadi
reviewed
Nov 5, 2024
| @@ -48,6 +48,7 @@ T = { properties = [ "invertible", "controllable", "differe | |||
| # strategy in PennyLane. | |||
| MultiControlledX = {} | |||
| QFT = {} | |||
| CosineWindow = {} | |||
willjmax
changed the title
qml.CosineWindowqml.CosineWindow
|
Closing as this PR is not needed since PennyLaneAI/catalyst#1166 has been merged |
willjmax
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Nov 11, 2024
Compiling a circuit with QJIT that begins with a CosineWindow state preparation results in a compiler error. This is because Catalyst has optimizations for when the first operation is a state preparation, but these optimizations are not supported for CosineWindow. A workaround is to only perform the state preparation optimizations on the `StatePrep` and `BasisState` classes, rather than the more general `StatePrepBase` class. The latest version of this PR makes the PRs to PennyLane [(PR #6318)](PennyLaneAI/pennylane#6318) and PennyLane lightning [(PR #929)](PennyLaneAI/pennylane-lightning#929) unnecessary. --------- Co-authored-by: Ali Asadi <[email protected]> Co-authored-by: David Ittah <[email protected]> Co-authored-by: erick-xanadu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling a circuit with QJIT that begins with a CosineWindow state preparation results in a compiler error. This is because Catalyst has optimizations for when the first operation is a state preparation, but these optimizations are not supported for CosineWindow. A workaround is to only perform the state preparation optimizations on the StatePrep and BasisState classes, rather than the more general StatePrepBase class.
This workaround requires additional changes to Catalyst (PR #1166) and PennyLane (PR #6318).