-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add controlled gate + matrix support to Lightning Kokkos #934
base: master
Are you sure you want to change the base?
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #934 +/- ##
===========================================
- Coverage 96.88% 53.38% -43.51%
===========================================
Files 215 28 -187
Lines 29522 2497 -27025
===========================================
- Hits 28603 1333 -27270
- Misses 919 1164 +245 ☔ View full report in Codecov by Sentry. |
35192c7
to
6b8ffa5
Compare
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Added support for multi-controlled gates and matrix for Lightning Kokkos, with an analogous interface to Lightning Qubit. Introduced
NC{x}QubitOpFunctor
for controlled-matrix operations andapplyNC{x}Functor
for controlled-gate operations.Benefits:
Possible Drawbacks:
Related GitHub Issues: