-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(LK-C-6) Add controlled generator (multi-qubit) support for Lightning Kokkos #958
base: lk-control-generator
Are you sure you want to change the base?
Conversation
Hello. You may have forgotten to update the changelog!
|
20bdb47
to
b70ca6b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## lk-control-generator #958 +/- ##
========================================================
+ Coverage 96.62% 96.64% +0.01%
========================================================
Files 221 221
Lines 35000 35197 +197
========================================================
+ Hits 33820 34017 +197
Misses 1180 1180 ☔ View full report in Codecov by Sentry. |
std::tie(parity, rev_wires) = | ||
reverseWires(num_qubits, wires, controlled_wires); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good candidate for a structured binding.
std::tie(parity, rev_wires) = | |
reverseWires(num_qubits, wires, controlled_wires); | |
auto [parity, rev_wires] = reverseWires(num_qubits, wires, controlled_wires); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to use structured binding now, thanks!
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
This PR adds support for 2/4-qubit controlled generator (e.g. IsingXX / SingleExcitation / DoubleExcitation) and MultiRZ to Lightning Kokkos.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-76778]