Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(LK-C-6) Add controlled generator (multi-qubit) support for Lightning Kokkos #958

Open
wants to merge 4 commits into
base: lk-control-generator
Choose a base branch
from

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Oct 23, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
This PR adds support for 2/4-qubit controlled generator (e.g. IsingXX / SingleExcitation / DoubleExcitation) and MultiRZ to Lightning Kokkos.
Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-76778]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@josephleekl josephleekl added ci:build_wheels Activate wheel building. urgent Mark a pull request as high priority ci:use-gpu-runner Enable usage of GPU runner for this Pull Request labels Oct 23, 2024
@josephleekl josephleekl marked this pull request as ready for review October 23, 2024 18:57
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (6abbda0) to head (f2dee3d).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           lk-control-generator     #958      +/-   ##
========================================================
+ Coverage                 96.62%   96.64%   +0.01%     
========================================================
  Files                       221      221              
  Lines                     35000    35197     +197     
========================================================
+ Hits                      33820    34017     +197     
  Misses                     1180     1180              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephleekl josephleekl changed the title Add controlled generator (multi-qubit) support for Lightning Kokkos (LK-C-6) Add controlled generator (multi-qubit) support for Lightning Kokkos Oct 23, 2024
Comment on lines 782 to 783
std::tie(parity, rev_wires) =
reverseWires(num_qubits, wires, controlled_wires);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good candidate for a structured binding.

Suggested change
std::tie(parity, rev_wires) =
reverseWires(num_qubits, wires, controlled_wires);
auto [parity, rev_wires] = reverseWires(num_qubits, wires, controlled_wires);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to use structured binding now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants