Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PTM stable latest #961

Merged
merged 12 commits into from
Oct 25, 2024
Merged

Fix PTM stable latest #961

merged 12 commits into from
Oct 25, 2024

Conversation

LuisAlfredoNu
Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu commented Oct 24, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
The PTM has an unexpected behaviour for Stable Lightnin - Latest PennyLane because on CIs looks like Latest PL reference to the last release instead of to master

Description of the Change:

Benefits:
Correct behavior for the PTM

Possible Drawbacks:

Related GitHub Issues:
[sc-76772]

@LuisAlfredoNu LuisAlfredoNu added ci:build_wheels Activate wheel building. urgent Mark a pull request as high priority labels Oct 24, 2024
@LuisAlfredoNu LuisAlfredoNu marked this pull request as ready for review October 24, 2024 15:52
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.78%. Comparing base (6d91c9a) to head (baea404).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (6d91c9a) and HEAD (baea404). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (6d91c9a) HEAD (baea404)
8 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #961       +/-   ##
===========================================
- Coverage   96.57%   53.78%   -42.80%     
===========================================
  Files         215       28      -187     
  Lines       30482     2495    -27987     
===========================================
- Hits        29439     1342    -28097     
- Misses       1043     1153      +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@multiphaseCFD
Copy link
Member

Thanks @LuisAlfredoNu . Could you please give more context in the description?

@mudit2812 mudit2812 self-requested a review October 24, 2024 21:42
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuisAlfredoNu ! LGTM. Just one comment

.github/workflows/tests_gpu_python.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuisAlfredoNu . Looks good to me. Just one comment about the git fetch --all command you used, but it's not a blocker.

.github/workflows/tests_gpu_python.yml Outdated Show resolved Hide resolved
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @LuisAlfredoNu ! Please get it merged once all CIs passed

@LuisAlfredoNu LuisAlfredoNu merged commit a55a58e into master Oct 25, 2024
98 of 99 checks passed
@LuisAlfredoNu LuisAlfredoNu deleted the fix_stable_latest branch October 25, 2024 15:11
@LuisAlfredoNu LuisAlfredoNu restored the fix_stable_latest branch October 25, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants