-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PTM stable latest #961
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #961 +/- ##
===========================================
- Coverage 96.57% 53.78% -42.80%
===========================================
Files 215 28 -187
Lines 30482 2495 -27987
===========================================
- Hits 29439 1342 -28097
- Misses 1043 1153 +110 ☔ View full report in Codecov by Sentry. |
Hello. You may have forgotten to update the changelog!
|
Thanks @LuisAlfredoNu . Could you please give more context in the description? |
…lightning into fix_stable_latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LuisAlfredoNu ! LGTM. Just one comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @LuisAlfredoNu . Looks good to me. Just one comment about the git fetch --all
command you used, but it's not a blocker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @LuisAlfredoNu ! Please get it merged once all CIs passed
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
The PTM has an unexpected behaviour for Stable Lightnin - Latest PennyLane because on CIs looks like Latest PL reference to the last release instead of to
master
Description of the Change:
Benefits:
Correct behavior for the PTM
Possible Drawbacks:
Related GitHub Issues:
[sc-76772]