Standard installation instruction visibility #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## update_installation_instructions #979 +/- ##
===================================================================
Coverage ? 28.57%
===================================================================
Files ? 28
Lines ? 2495
Branches ? 0
===================================================================
Hits ? 713
Misses ? 1782
Partials ? 0 ☔ View full report in Codecov by Sentry. |
maliasadi
reviewed
Nov 6, 2024
.github/CHANGELOG.md
Outdated
Comment on lines
126
to
127
| * Update Lightning-Tensor installation docs and usage suggestions. | ||
| [(#979)](https://github.com/PennyLaneAI/pennylane-lightning/pull/979) |
There was a problem hiding this comment.
Hi @AntonNI8, what's the status of this PR?
There was a problem hiding this comment.
Hey @maliasadi , I just wanted to make some tweaks to the installation instructions for the lightning devices, but figured it would be best to wait until all of the v0.39 release work had been completed.
Pending reviews, I think we can go ahead with it.
DSGuala
approved these changes
Nov 11, 2024
AntonNI8
changed the base branch from
update_installation_instructions
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The standard (default, preferred) installation instructions in the pennylane-lightning docs are easy to miss.
This could discourage users if they think they need to go through a more involved installation process, ie. installing from source.
Description of the Change:
Added a heading for standard installation instructions.
Benefits:
Easier to notice the most simple/straightforward installation method for lightning devices.
Possible Drawbacks:
Related GitHub Issues: