Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pennylane dependency rc to master v0.39 release #984

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Nov 6, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@multiphaseCFD multiphaseCFD marked this pull request as ready for review November 6, 2024 21:52
Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @multiphaseCFD

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.56%. Comparing base (74211a7) to head (76b77f2).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (74211a7) and HEAD (76b77f2). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (74211a7) HEAD (76b77f2)
15 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #984       +/-   ##
===========================================
- Coverage   93.71%   53.56%   -40.16%     
===========================================
  Files         221       28      -193     
  Lines       32648     2513    -30135     
===========================================
- Hits        30595     1346    -29249     
+ Misses       2053     1167      -886     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@josephleekl josephleekl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @multiphaseCFD

@multiphaseCFD multiphaseCFD added the urgent Mark a pull request as high priority label Nov 6, 2024
@multiphaseCFD multiphaseCFD merged commit dc950bf into master Nov 6, 2024
68 of 70 checks passed
@multiphaseCFD multiphaseCFD deleted the revert_rc_2_master_0.39 branch November 6, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants