-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update Lightning device TOML files to the new schema #988
base: master
Are you sure you want to change the base?
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #988 +/- ##
===========================================
- Coverage 97.97% 28.46% -69.51%
===========================================
Files 221 28 -193
Lines 33726 2508 -31218
===========================================
- Hits 33043 714 -32329
- Misses 683 1794 +1111 ☔ View full report in Codecov by Sentry. |
…htning into toml-updates
@@ -18,4 +18,4 @@ cmake | |||
custatevec-cu12 | |||
cutensornet-cu12 | |||
pylint==2.7.4 | |||
git+https://github.com/PennyLaneAI/pennylane.git@master | |||
git+https://github.com/PennyLaneAI/pennylane.git@device-api-cap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: revert this
Context:
This PR is part of the new device capabilities initiative to improve feature parity across the ecosystem. See this ADR for more context. A new TOML schema has been defined, and the relevant module implemented in PennyLane:
DeviceCapabilities
data class and the TOML module. pennylane#6407capabilities
to the device API pennylane#6433.As well as updates made to Catalyst:
Description of the Change:
lightning_qubit.toml
,lightning_kokkos.toml
,lightning_gpu.toml
to the new schema_operations
and_observables
fromLightningQubit
,LightningKokkos
, andLightningGPU
as they are now available viaDevice.capabilities
that is loaded from the TOML file.Benefits:
A step towards feature parity across the ecosystem.
Possible Drawbacks:
operator.gates.decomp
andoperator.gates.matrix
are removed, and the TOML file no longer prescribes to the framework how an operator should be handled. To ensure consistency of behaviour, this information is temporarily moved to a_to_matrix_ops
class property to be used by Catalyst, until we have better support for customizable multi-pathway decompositions.Related GitHub Issues:
[sc-71729]