-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TestPyPI tokens from wheel recipes #989
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #989 +/- ##
===========================================
- Coverage 97.97% 53.60% -44.38%
===========================================
Files 221 28 -193
Lines 33726 2511 -31215
===========================================
- Hits 33043 1346 -31697
- Misses 683 1165 +482 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please provide more context for this PR?
Perhaps filling the PR description.
@AmintorDusko Didn't expect your review to be this fast 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great work! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @maliasadi
Thank you!!! 🚀
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Currently, Linux and macOS (x86_64 & AARCH64) wheels are failing due to the use of older legacy tokens during the upload to TestPyPI. This PR fixes the issue by registering the wheel recipes as Trusted Publishing and increases the verbosity of this action step to provide a detailed description for future failures.
Description of the Change:
Benefits:
No need to use secret tokens as these actions are now registered as TP at https://test.pypi.org/
Possible Drawbacks:
Related GitHub Issues:
[sc-77894]