Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TestPyPI tokens from wheel recipes #989

Merged
merged 8 commits into from
Nov 11, 2024
Merged

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Nov 8, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Currently, Linux and macOS (x86_64 & AARCH64) wheels are failing due to the use of older legacy tokens during the upload to TestPyPI. This PR fixes the issue by registering the wheel recipes as Trusted Publishing and increases the verbosity of this action step to provide a detailed description for future failures.

Description of the Change:

Benefits:
No need to use secret tokens as these actions are now registered as TP at https://test.pypi.org/

Possible Drawbacks:

Related GitHub Issues:

[sc-77894]

Copy link
Contributor

github-actions bot commented Nov 8, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.60%. Comparing base (d2aa04d) to head (3373309).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (d2aa04d) and HEAD (3373309). Click for more details.

HEAD has 45 uploads less than BASE
Flag BASE (d2aa04d) HEAD (3373309)
50 5
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #989       +/-   ##
===========================================
- Coverage   97.97%   53.60%   -44.38%     
===========================================
  Files         221       28      -193     
  Lines       33726     2511    -31215     
===========================================
- Hits        33043     1346    -31697     
- Misses        683     1165      +482     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide more context for this PR?
Perhaps filling the PR description.

@maliasadi
Copy link
Member Author

@AmintorDusko Didn't expect your review to be this fast 😄

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work! Thanks!

Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @maliasadi
Thank you!!! 🚀

@maliasadi maliasadi merged commit b491a37 into master Nov 11, 2024
54 of 55 checks passed
@maliasadi maliasadi deleted the rm_testpypi_tokens branch November 11, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants