Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change back to QuantumCircuit.from_qasm_str #581

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

lillian542
Copy link
Contributor

When updating QASM load functionality recently, we switched from QuantumCircuit.from_qasm_str to qiskit.qasm2.loads for loading a QASM string into a QiskitCircuit. But qiskit.qasm2.loads seems not to support as many operations as QuantumCircuit.from_qasm_str, and specifically is failing to load the u gate.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (170fa78) to head (577073f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #581   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          867       866    -1     
=========================================
- Hits           867       866    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@KetpuntoG KetpuntoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lillian542 lillian542 merged commit 0f7a9bf into master Aug 29, 2024
10 checks passed
@lillian542 lillian542 deleted the revert_qasm2_change branch August 29, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants