[Proposal] Remove old benchmarks from Readme #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No blocker from me. I'll leave @trbromley and another to approve. |
|
Do we have reason to believe that the benchmark timings are significantly different now versus then? |
Yes, they are very different. |
Are we able to update instead of remove? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to remove the benchmarks from the readme until such time as we have updated benchmarks.
The table is four years old, and the graph is over a year old. We also have no idea what the simulations were run on, other than it is potentially something with 48 available cores.
The benchmarks also provide no information about what was measured. Single expectation value?
If we are to advertise benchmarks for the plugin, they should be maintained routinely, and fully specified.