Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "sqrt_matrix" to working in tensorflow graph mode #4586

Closed
wants to merge 0 commits into from

Conversation

vinayak19th
Copy link

Before submitting

Please complete the following checklist when submitting a PR:

  • [x ] All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the doc/releases/changelog-dev.md file, summarizing the
    change, and including a link back to the PR.

  • The PennyLane source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint pennylane/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
When using qml.math.fidelity, it calls the "sqrt_matrix" function. This function has a cast call when not using an abstract vector. However, this causes issues when running in a tensorflow graph mode.

When executing in graph mode with tensorflow, the multiply operation

vecs @ sqrt_evs @ qml.math.conj(qml.math.transpose(vecs, (0, 2, 1)))

causes a type error as both the eigenvectors are of type "complex" and the sqrt values are "float". This seems to be specific to the broadcast case.

Description of the Change:

Added a typecast call to fix this issue:

sqrt_evs = qml.math.expand_dims(qml.math.sqrt(evs), 1) * i
+ sqrt_evs = qml.math.cast_like(sqrt_evs, vecs)
- return vecs @ sqrt_evs @ qml.math.conj(qml.math.transpose(vecs, (0, 2, 1)))
+ return qml.math.real(vecs @ sqrt_evs @ qml.math.conj(qml.math.transpose(vecs, (0, 2, 1))))

Also added a qml.real to handle typecast warnings when converting from complex -> float. As the product is guaranteed to be real, this will not cause any problems.

Benefits:
The fidelity function can now be used with batched tensors in graph mode.

Possible Drawbacks:
None

Related GitHub Issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant