Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define BasisStateProjector.compute_sparse_matrix #5790

Merged
merged 26 commits into from
Jul 24, 2024

Conversation

AnuravModak
Copy link
Contributor

Towards #5721.

Signed-off-by: Anurav Modak <[email protected]>
Signed-off-by: Anurav Modak <[email protected]>
@AnuravModak
Copy link
Contributor Author

Hi, Let me know if i need to do any further changes on this, here i could see some conflicting files but the resolve conflicts option is disabled!! Let me know what else could be done from my side.

pennylane/_device.py Outdated Show resolved Hide resolved
pennylane/drawer/utils.py Outdated Show resolved Hide resolved
tests/test_qaoa.py Outdated Show resolved Hide resolved
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the delay. Notifications sometimes just get a bit buried.

I cleaned up some formating changes in other parts of the code. We try to make global stylistic changes in dedicated stylistic PR's, and keep code changes localized to the relevant parts of the code. Otherwise, it can be easy to miss an actual code change buried in stylistic changes, difficult to quickly estimate the scope and impact of a PR, and keep an accurate git history.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (a456fce) to head (0d31bc1).
Report is 295 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5790      +/-   ##
==========================================
- Coverage   99.65%   99.65%   -0.01%     
==========================================
  Files         428      428              
  Lines       41160    40872     -288     
==========================================
- Hits        41020    40731     -289     
- Misses        140      141       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@PietropaoloFrisoni PietropaoloFrisoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AnuravModak!

Just a couple of comments from my end : )

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
doc/releases/changelog-dev.md Show resolved Hide resolved
@PietropaoloFrisoni PietropaoloFrisoni enabled auto-merge (squash) July 24, 2024 20:36
@PietropaoloFrisoni PietropaoloFrisoni merged commit 4d16acb into PennyLaneAI:master Jul 24, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants