-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define BasisStateProjector.compute_sparse_matrix #5790
Conversation
Signed-off-by: Anurav Modak <[email protected]>
Signed-off-by: Anurav Modak <[email protected]>
Signed-off-by: Anurav Modak <[email protected]>
Signed-off-by: Anurav Modak <[email protected]>
Signed-off-by: Anurav Modak <[email protected]>
Signed-off-by: Anurav Modak <[email protected]>
Signed-off-by: Anurav Modak <[email protected]>
Signed-off-by: Anurav Modak <[email protected]>
Signed-off-by: Anurav Modak <[email protected]>
Signed-off-by: Anurav Modak <[email protected]>
Signed-off-by: Anurav Modak <[email protected]>
Signed-off-by: Anurav Modak <[email protected]>
Hi, Let me know if i need to do any further changes on this, here i could see some conflicting files but the resolve conflicts option is disabled!! Let me know what else could be done from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay. Notifications sometimes just get a bit buried.
I cleaned up some formating changes in other parts of the code. We try to make global stylistic changes in dedicated stylistic PR's, and keep code changes localized to the relevant parts of the code. Otherwise, it can be easy to miss an actual code change buried in stylistic changes, difficult to quickly estimate the scope and impact of a PR, and keep an accurate git history.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5790 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 428 428
Lines 41160 40872 -288
==========================================
- Hits 41020 40731 -289
- Misses 140 141 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AnuravModak!
Just a couple of comments from my end : )
Towards #5721.