-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean unflatten
in PrepSelPrep
#5987
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5987 +/- ##
==========================================
- Coverage 99.66% 99.65% -0.01%
==========================================
Files 427 427
Lines 41060 40762 -298
==========================================
- Hits 40922 40622 -300
- Misses 138 140 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Thomas R. Bromley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks for this fix :)
@@ -14,6 +14,8 @@ | |||
combination of unitaries. | |||
[(#5756)](https://github.com/PennyLaneAI/pennylane/pull/5756) | |||
|
|||
[(#5987)](https://github.com/PennyLaneAI/pennylane/pull/5987) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflict?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry you are right! let me fix that
[sc-68516] |
Context:
LinearCombination was being cast within unflaten. It has been moved to init to avoid issues