Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean unflatten in PrepSelPrep #5987

Merged
merged 6 commits into from
Jul 22, 2024
Merged

clean unflatten in PrepSelPrep #5987

merged 6 commits into from
Jul 22, 2024

Conversation

KetpuntoG
Copy link
Contributor

Context:

LinearCombination was being cast within unflaten. It has been moved to init to avoid issues

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (ee4e7de) to head (1fd08d5).
Report is 295 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5987      +/-   ##
==========================================
- Coverage   99.66%   99.65%   -0.01%     
==========================================
  Files         427      427              
  Lines       41060    40762     -298     
==========================================
- Hits        40922    40622     -300     
- Misses        138      140       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@astralcai astralcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Thomas R. Bromley <[email protected]>
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for this fix :)

@KetpuntoG KetpuntoG enabled auto-merge (squash) July 22, 2024 13:47
@KetpuntoG KetpuntoG merged commit 3ad15d7 into master Jul 22, 2024
40 checks passed
@KetpuntoG KetpuntoG deleted the fix_prepselprep branch July 22, 2024 14:59
@@ -14,6 +14,8 @@
combination of unitaries.
[(#5756)](https://github.com/PennyLaneAI/pennylane/pull/5756)

[(#5987)](https://github.com/PennyLaneAI/pennylane/pull/5987)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry you are right! let me fix that

@KetpuntoG
Copy link
Contributor Author

[sc-68516]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants