-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating Legacy Devices #5997
Conversation
Co-authored-by: Thomas R. Bromley <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5997 +/- ##
==========================================
- Coverage 99.65% 99.65% -0.01%
==========================================
Files 428 428
Lines 41160 40883 -277
==========================================
- Hits 41020 40742 -278
- Misses 140 141 +1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Thomas R. Bromley <[email protected]>
Co-authored-by: Thomas R. Bromley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Minor non-blocking comment above.
Co-authored-by: Mudit Pandey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me so happy :)
Overview of deprecation changes:
conftest.py
for capturing warnings. This should capture any uncaptured warnings from the tests (read, the deprecation warnings from the legacy devices), and therefore works as expected and shouldn't cause any issues.default.qubit
folder one level, and added missing tests from the legacy tests to the DQ's tests. This should make the removal process much easier by simply deleting a folder and pulling a bunch of files up a directory.pulse
module (and related misc. files) that were relying on legacy devices and updated the code block accordingly.default.qubit.legacy
todefault.mixed
for tests testing the old device interface, and not simply the legacy itself.[sc-66694]