Allow qml.cond to fallback to the Python interpreter if a compiler is not available and there are no MCMs
#6016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nterpreter if a compiler is not available.
…is not available and there are no MCMs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6016 +/- ##
==========================================
+ Coverage 99.52% 99.65% +0.13%
==========================================
Files 430 430
Lines 41835 41436 -399
==========================================
- Hits 41637 41295 -342
+ Misses 198 141 -57 ☔ View full report in Codecov by Sentry. |
|
[sc-69157] |
dime10
reviewed
Jul 22, 2024
Co-authored-by: Christina Lee <[email protected]>
|
Thanks @PietropaoloFrisoni, I've just resolved the conflicts! |
mudit2812
approved these changes
Aug 1, 2024
…into `CondCallable` (#6063) **Context:** For 'historical reasons', the captured version (see sc-66774) and the non-captured version (see sc-69157) of `qml.cond` have a different style, which is rather uneven. The purpose of this story is to incorporate them in such a way that the implementation is more similar to the one in Catalyst. Or, to make another example, the implementation of `qml.for_loop` in PL (see sc-66736 and sc-69432). The purpose is not to change/add functionalities, but rather to unify the code structure so that it is more elegant. **Description of the Change:** As above. **Benefits:** Better and cleaner structure, more similar to Catalyst. **Possible Drawbacks:** None that I can think of right now directly due to this PR (we just moved some code). **Related GitHub Issues:** None **Related Shortcut Stories:** [sc-70342]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
In Catalyst,
catalyst.condwill seamlessly fallback to Python interpretation when@qjitis not present. However,qml.condwill instead raise an error when@qjitis not present and the condition is not a mid-circuit measurement, which is not ideal.Description of the Change:
When
@qjitis not present and the conditional does not contain a mid-circuit measurement,qml.condwill now simply execute the conditional in standard Python.qml.condcan be optionally used in decorator mode (matching the behaviour ofcatalyst.cond).Benefits:
This will allow the same code to work with and without
@qjit, without needing to modify the workflow.This will also allow templates and operation decompositions to use
qml.condinternally, with no changes for standard Python execution, but with conditionals captured automatically when using@qjit.Possible Drawbacks:
Not a drawback per se, more of a note, but the
CondCallableclass introduced in this PR might be needed (and extended) to support capturing for conditional statements as JAXPR primitives(?). It is based on the equivalent classes from Catalyst.Introduces an additional decorator UI. This is not documented for now, but it will easily allow existing Catalyst code to port from using
catalyst.condtoqml.cond.Related GitHub Issues: n/a