-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the internal switching of a backpropagation device #6032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Thomas R. Bromley <[email protected]>
Co-authored-by: Thomas R. Bromley <[email protected]>
Co-authored-by: Thomas R. Bromley <[email protected]>
Co-authored-by: Thomas R. Bromley <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
albi3ro
commented
Jul 23, 2024
Shiro-Raven
reviewed
Jul 23, 2024
Co-authored-by: Ahmed Darwish <[email protected]>
Shiro-Raven
approved these changes
Jul 23, 2024
albi3ro
commented
Jul 26, 2024
mudit2812
reviewed
Jul 26, 2024
mudit2812
reviewed
Jul 26, 2024
mudit2812
approved these changes
Jul 26, 2024
Co-authored-by: Mudit Pandey <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6032 +/- ##
==========================================
- Coverage 99.66% 99.65% -0.01%
==========================================
Files 428 428
Lines 41182 40889 -293
==========================================
- Hits 41042 40748 -294
- Misses 140 141 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The internal switching of one device for another backpropagation-compatible device was developed to allow the substitution of
default.qubit.legacy
with eitherdefault.qubit.autograd
,default.qubit.jax
,default.qubit.torch
, ordefault.qubit.tf
. This logic has caused a lot of pain over the years, and all five of those devices are now deprecated. In order to complete the removal of the 5 legacy devices, we need to also deprecate and remove the backprop device switching logic.Otherwise, it would be very difficult and painful to test the switching of a backpropagation device.
Description of the Change:
Deprecates the switching of a device with a different device. A warning is only raised when the device is not
default.qubit.legacy
, as default.qubit.legacy raises it's own deprecation warnings.Benefits:
We can finally clean up QNode 🎉 💥
Possible Drawbacks:
Related GitHub Issues: