Update datasets to use API #6126
Open
+989
−305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6126 +/- ##
==========================================
+ Coverage 99.58% 99.69% +0.11%
==========================================
Files 443 444 +1
Lines 42273 42141 -132
==========================================
- Hits 42096 42012 -84
+ Misses 177 129 -48 ☔ View full report in Codecov by Sentry. |
….com:PennyLaneAI/pennylane into sc-70918-pennylane-oss-uses-new-datasets-api
brownj85
reviewed
Sep 19, 2024
Comment on lines
35
to
+36
|
|
||
| GRAPHQL_URL = "https://cloud.pennylane.ai/graphql" |
There was a problem hiding this comment.
Suggested change
| GRAPHQL_URL = "https://cloud.pennylane.ai/graphql" | |
| import os | |
| GRAPHQL_URL = os.getenv("DATASETS_ENDPOINT_URL", "https://cloud.pennylane.ai/graphql") |
It'll be useful to be able to override this for testing new datasets
| branch = parameter_tree | ||
| choices = [] | ||
| for param in parameters: | ||
| print(f"Available options for {param}:") |
There was a problem hiding this comment.
- We should move the leaf check to the top of the loop, this is helpful because it guarantees that
branchis always a non-leaf node in the rest of the loop - A leaf node is a
str, not adict
Suggested change
| print(f"Available options for {param}:") | |
| if isinstance(branch, str): | |
| break | |
| if len(branch["next"]) == 1: | |
| branch = next(iter(branch["next"].values())) | |
| continue | |
| print(f"Available options for {param}:") |
| branch = branch["next"][user_value] | ||
| except KeyError as e: | ||
| raise ValueError(f"Must enter a valid {param}:") from e | ||
| choices.append(user_value) |
There was a problem hiding this comment.
Suggested change
| choices.append(user_value) |
I don't think we need choices since we're not returning it
Comment on lines
+549
to
+553
| if "next" in branch: | ||
| if len(branch["next"]) == 1: | ||
| branch = next(iter(branch["next"].values())) | ||
| continue | ||
| branch = branch["value"] |
There was a problem hiding this comment.
Suggested change
| if "next" in branch: | |
| if len(branch["next"]) == 1: | |
| branch = next(iter(branch["next"].values())) | |
| continue | |
| branch = branch["value"] |
Since we moved this logic to the top of the loop
| """Prompts the user to select parameters for datasets one at a time.""" | ||
|
|
||
| branch = parameter_tree | ||
| choices = [] |
There was a problem hiding this comment.
Suggested change
| choices = [] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Datasets are currently downloaded by hitting the S3 bucket (via CloudFront) where the
.h5files are stored. This PR updates the way datasets are downloaded by directing download requests to the Software Cloud managed Datasets Service.Description of the Change:
The
qml.data.loadfunction now queries the Datasets API in order to download datasets.Benefits:
foldermapanddata_structfiles, alleviating the need to manually manage them.Possible Drawbacks:
Related GitHub Issues: