Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update casting for apply_operation #6268

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Update casting for apply_operation #6268

merged 6 commits into from
Sep 20, 2024

Conversation

mudit2812
Copy link
Contributor

@mudit2812 mudit2812 commented Sep 13, 2024

  • Update casting for matrices in qml.devices.qubit.apply_operation. For some reason the old casting was making jax happy but not autograd.
  • Remove the 0.38.1 changelog. @josh146 confirmed that we should do this now that the release has been yanked from PyPi.

@mudit2812 mudit2812 marked this pull request as ready for review September 13, 2024 15:36
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@mudit2812 mudit2812 marked this pull request as draft September 13, 2024 21:36
@mudit2812 mudit2812 marked this pull request as ready for review September 20, 2024 17:40
@mudit2812
Copy link
Contributor Author

I'm going to open a temporary PR in qml to promote ComplexWarnings to errors and install this branch to verify that all warnings are fixed after this PR is merged.

@PietropaoloFrisoni
Copy link
Contributor

I'm going to open a temporary PR in qml to promote ComplexWarnings to errors and install this branch to verify that all warnings are fixed after this PR is merged.

Makes sense! Are these failures expected?

@mudit2812
Copy link
Contributor Author

I'm going to open a temporary PR in qml to promote ComplexWarnings to errors and install this branch to verify that all warnings are fixed after this PR is merged.

Makes sense! Are these failures expected?

@PietropaoloFrisoni In hindsight, I should've expected those failures. I've fixed them now by having a separate branch for casting when the interface is "tensorflow".

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (de54c54) to head (6ccb3fb).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6268   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files         444      444           
  Lines       42133    42202   +69     
=======================================
+ Hits        42008    42079   +71     
+ Misses        125      123    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mudit2812 mudit2812 enabled auto-merge (squash) September 20, 2024 20:23
@mudit2812 mudit2812 merged commit 6d98c51 into master Sep 20, 2024
37 checks passed
@mudit2812 mudit2812 deleted the implicit-casting branch September 20, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants