-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous deprecations #6277
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6277 +/- ##
==========================================
+ Coverage 99.58% 99.59% +0.01%
==========================================
Files 443 444 +1
Lines 42273 42341 +68
==========================================
+ Hits 42096 42168 +72
+ Misses 177 173 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @mudit2812 💯
Just had a few minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Co-authored-by: David Wierichs <[email protected]> Co-authored-by: lillian542 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mudit2812
* Deprecate `qml.broadcast`. * Deprecate `qml.shadows.shadow_expval`. * Deprecate the `'ancilla'` argument of `qml.iterative_qpe`in favour of `aux_wire`. [sc-69798] [sc-72497] [sc-71185] --------- Co-authored-by: David Wierichs <[email protected]> Co-authored-by: lillian542 <[email protected]>
* Deprecate `qml.broadcast`. * Deprecate `qml.shadows.shadow_expval`. * Deprecate the `'ancilla'` argument of `qml.iterative_qpe`in favour of `aux_wire`. [sc-69798] [sc-72497] [sc-71185] --------- Co-authored-by: David Wierichs <[email protected]> Co-authored-by: lillian542 <[email protected]>
qml.broadcast
.qml.shadows.shadow_expval
.'ancilla'
argument ofqml.iterative_qpe
in favour ofaux_wire
.[sc-69798] [sc-72497] [sc-71185]