Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous deprecations #6277

Merged
merged 14 commits into from
Sep 17, 2024
Merged

Miscellaneous deprecations #6277

merged 14 commits into from
Sep 17, 2024

Conversation

mudit2812
Copy link
Contributor

@mudit2812 mudit2812 commented Sep 17, 2024

  • Deprecate qml.broadcast.
  • Deprecate qml.shadows.shadow_expval.
  • Deprecate the 'ancilla' argument of qml.iterative_qpein favour of aux_wire.

[sc-69798] [sc-72497] [sc-71185]

@mudit2812 mudit2812 marked this pull request as ready for review September 17, 2024 15:23
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (b78565c) to head (78644bb).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6277      +/-   ##
==========================================
+ Coverage   99.58%   99.59%   +0.01%     
==========================================
  Files         443      444       +1     
  Lines       42273    42341      +68     
==========================================
+ Hits        42096    42168      +72     
+ Misses        177      173       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lillian542 lillian542 self-requested a review September 17, 2024 17:53
@dwierichs dwierichs self-requested a review September 17, 2024 17:54
Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mudit2812 💯
Just had a few minor comments.

doc/development/deprecations.rst Outdated Show resolved Hide resolved
doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
pennylane/devices/_qubit_device.py Show resolved Hide resolved
pennylane/ops/functions/iterative_qpe.py Show resolved Hide resolved
pennylane/templates/broadcast.py Outdated Show resolved Hide resolved
pennylane/templates/subroutines/arbitrary_unitary.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@dwierichs dwierichs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mudit2812

@mudit2812 mudit2812 enabled auto-merge (squash) September 17, 2024 18:55
@mudit2812 mudit2812 merged commit a40e3e7 into master Sep 17, 2024
37 checks passed
@mudit2812 mudit2812 deleted the dep/broadcast-ancilla-shadow branch September 17, 2024 19:52
mudit2812 added a commit that referenced this pull request Sep 18, 2024
* Deprecate `qml.broadcast`.
* Deprecate `qml.shadows.shadow_expval`.
* Deprecate the `'ancilla'` argument of `qml.iterative_qpe`in favour of
`aux_wire`.

[sc-69798] [sc-72497] [sc-71185]

---------

Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: lillian542 <[email protected]>
mudit2812 added a commit that referenced this pull request Sep 23, 2024
* Deprecate `qml.broadcast`.
* Deprecate `qml.shadows.shadow_expval`.
* Deprecate the `'ancilla'` argument of `qml.iterative_qpe`in favour of
`aux_wire`.

[sc-69798] [sc-72497] [sc-71185]

---------

Co-authored-by: David Wierichs <[email protected]>
Co-authored-by: lillian542 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants