Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct some typos across the codebase #6280

Merged
merged 14 commits into from
Sep 20, 2024
Merged

Correct some typos across the codebase #6280

merged 14 commits into from
Sep 20, 2024

Conversation

dwierichs
Copy link
Contributor

Context:
As title says.

Description of the Change:

Benefits:
Fewer typos.
A unified way to write the word "parametrize", which coincides with the naming of classes like ParametrizedEvolution or pytest's function mark.parametrize.

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@lillian542 lillian542 self-requested a review September 18, 2024 20:19
@mudit2812 mudit2812 self-requested a review September 18, 2024 20:28
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the individual changes are so small, optional suggestion to add a changelog entry under the "Documentation" section, but otherwise LGTM!

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (de54c54) to head (a23e281).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6280   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files         444      444           
  Lines       42133    42133           
=======================================
  Hits        42008    42008           
  Misses        125      125           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PietropaoloFrisoni
Copy link
Contributor

Thanks @dwierichs! I suggested one more change in this PR (I noticed it this morning)

@dwierichs dwierichs enabled auto-merge (squash) September 19, 2024 07:08
@dwierichs dwierichs merged commit 1962f1c into master Sep 20, 2024
37 checks passed
@dwierichs dwierichs deleted the spelling branch September 20, 2024 08:28
mudit2812 pushed a commit that referenced this pull request Sep 23, 2024
**Context:**
As title says.

**Description of the Change:**

**Benefits:**
Fewer typos.
A unified way to write the word "parametrize", which coincides with the
naming of classes like `ParametrizedEvolution` or pytest's function
`mark.parametrize`.

**Possible Drawbacks:**

**Related GitHub Issues:**

---------

Co-authored-by: Pietropaolo Frisoni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants