-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where unexpected queuing occurs in qml.ctrl
among other functions
#6284
Closed
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0a01915 - Browse repository at this point
Copy the full SHA 0a01915View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8d2048 - Browse repository at this point
Copy the full SHA e8d2048View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4de0ac3 - Browse repository at this point
Copy the full SHA 4de0ac3View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcbcb87 - Browse repository at this point
Copy the full SHA fcbcb87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 000b88d - Browse repository at this point
Copy the full SHA 000b88dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e921546 - Browse repository at this point
Copy the full SHA e921546View commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bfee7c0 - Browse repository at this point
Copy the full SHA bfee7c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36c2a20 - Browse repository at this point
Copy the full SHA 36c2a20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 342a92c - Browse repository at this point
Copy the full SHA 342a92cView commit details
Commits on Oct 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 661dd52 - Browse repository at this point
Copy the full SHA 661dd52View commit details -
Use
pytest-rng
generated seeds for stochastic tests (#6435)**Context:** The PennyLane CI suffers from sporadic failures due to stochasticity of test cases. In order to save CI runtime, we have seeded many tests. However, this approach introduces the risk of a test case passing due to a special seed, potentially hiding bugs that could have been discovered. Therefore, it is beneficial to periodically update the seeds to review such tests. **Description of the Change:** - The test suite uses `pytest-rng` to handle seed generation. A `seed` fixture is now available to use for every test case. If seeding is required, please use the seed provided by `pytest-rng` ```python def test_some_function(..., seed): dev = qml.device("default.qubit", seed=seed) ``` - A `local_salt` test marker has been added that allows you to modify the seed locally for a particular test case if the generated seed happens to make your test fail. ```python @pytest.mark.local_salt(42) def test_some_function(..., seed): dev = qml.device("default.qubit", seed=seed) ``` - All tests that uses local seeds has been updated to use the new seeding approach. - An `rng_salt` has been added to `pytest.ini`. This controls the seed generation for the entire test suite. We want to periodically change this `rng_salt` which updates all the seeds across the test suite. - The fixture that sets the global seed for every test case has been removed, and another fixture is added that restores the global seed after each test in case the test modifies the global seed. **Benefits:** We will be able to catch bugs hidden in tests that are passing only because of a magic seed that was set locally. **Possible Drawbacks:** This is a chore to maintain this seed an ensure that all tests pass with the new salt when it is updated. **Related Shortcut Story:** [sc-74294] --------- Co-authored-by: Mudit Pandey <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8dde8f8 - Browse repository at this point
Copy the full SHA 8dde8f8View commit details
Commits on Oct 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ce0ab85 - Browse repository at this point
Copy the full SHA ce0ab85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fafc93 - Browse repository at this point
Copy the full SHA 7fafc93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3324b8e - Browse repository at this point
Copy the full SHA 3324b8eView commit details -
Merge branch 'queueing_controls' of https://github.com/PennyLaneAI/pe…
…nnylane into queueing_controls
Configuration menu - View commit details
-
Copy full SHA for 30ec1d1 - Browse repository at this point
Copy the full SHA 30ec1d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4f55e0 - Browse repository at this point
Copy the full SHA e4f55e0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.