Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cotransform of quantum_fisher #6350

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Conversation

dwierichs
Copy link
Contributor

@dwierichs dwierichs commented Oct 7, 2024

Context:
quantum_fisher does not respect the classical Jacobian of a QNode, because its classical_cotransform is not set.

Description of the Change:
Set the same classical_cotransform as adjoint_metric_tensor and metric_tensor.

Benefits:

Possible Drawbacks:

Related GitHub Issues:
Fixes #6345

Related Shortcut Stories:
[sc-75092]

@dwierichs dwierichs changed the title fix, test, changelog Fix cotransform of quantum_fisher Oct 7, 2024
@dwierichs dwierichs marked this pull request as ready for review October 7, 2024 14:01
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dwierichs dwierichs enabled auto-merge (squash) October 7, 2024 14:26
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.39%. Comparing base (aae08b7) to head (0340a9e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6350      +/-   ##
==========================================
- Coverage   99.71%   99.39%   -0.32%     
==========================================
  Files         445      445              
  Lines       42285    42286       +1     
==========================================
- Hits        42165    42031     -134     
- Misses        120      255     +135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albi3ro albi3ro disabled auto-merge October 7, 2024 14:47
@albi3ro albi3ro merged commit f1ab2bc into master Oct 7, 2024
36 of 37 checks passed
@albi3ro albi3ro deleted the fix-quantum_fisher-cotransform branch October 7, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Discrepancy between quantum_fisher and adjoint_metric_tensor depending on angle order
3 participants