Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Device Capabilities] Add capabilities to the device API #6433

Open
wants to merge 96 commits into
base: master
Choose a base branch
from

Conversation

astralcai
Copy link
Contributor

Follow up PR to #6407, adds capabilities to the device API.

[sc-71716]
[sc-71709]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.30%. Comparing base (297e573) to head (69967f6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6433   +/-   ##
=======================================
  Coverage   99.29%   99.30%           
=======================================
  Files         457      457           
  Lines       43413    43449   +36     
=======================================
+ Hits        43109    43148   +39     
+ Misses        304      301    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albi3ro
Copy link
Contributor

albi3ro commented Nov 11, 2024

/github/workspace/doc/releases/changelog-dev.md: WARNING: document isn't included in any toctree

Maybe a merge conflict or something?

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two non-blocking comments about the documentation, looks great 🎉

These two tasks can be extracted into private methods or helper functions if that improves source code organization.
PennyLane can potentially provide a default implementation of the preprocessing program which should
be sufficient for most plugin devices. This requires that a TOML-formatted configuration file is
defined for your device. The details of this configuration file is described the next section. The
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make "the next section" a hyperlink here?

be sufficient for most plugin devices. This requires that a TOML-formatted configuration file is
defined for your device. The details of this configuration file is described the next section. The
default preprocessing program will be constructed based on what is declared in this file if provided.
Alternatively, you could override the :meth:`~.devices.Device.preprocess` method with a completely
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just personal preference, but this sentence gets lost when I skim the text, so the next line becomes disorienting and I have to go back and re-read.

Could the line break be right before "Alternatively" instead of right after "implementation", so that this in the same paragraph as the next sentence? One paragraph --> one concept is easier to skim through for relevant information.

pennylane/devices/capabilities.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants