-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Device Capabilities] Add capabilities
to the device API
#6433
base: master
Are you sure you want to change the base?
Conversation
…ss and the TOML module
This reverts commit 93b7883.
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6433 +/- ##
=======================================
Coverage 99.29% 99.30%
=======================================
Files 457 457
Lines 43413 43449 +36
=======================================
+ Hits 43109 43148 +39
+ Misses 304 301 -3 ☔ View full report in Codecov by Sentry. |
Maybe a merge conflict or something? |
Co-authored-by: Christina Lee <[email protected]>
This reverts commit 005c1ec.
…o device-api-cap
…o device-api-cap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two non-blocking comments about the documentation, looks great 🎉
These two tasks can be extracted into private methods or helper functions if that improves source code organization. | ||
PennyLane can potentially provide a default implementation of the preprocessing program which should | ||
be sufficient for most plugin devices. This requires that a TOML-formatted configuration file is | ||
defined for your device. The details of this configuration file is described the next section. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make "the next section" a hyperlink here?
be sufficient for most plugin devices. This requires that a TOML-formatted configuration file is | ||
defined for your device. The details of this configuration file is described the next section. The | ||
default preprocessing program will be constructed based on what is declared in this file if provided. | ||
Alternatively, you could override the :meth:`~.devices.Device.preprocess` method with a completely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just personal preference, but this sentence gets lost when I skim the text, so the next line becomes disorienting and I have to go back and re-read.
Could the line break be right before "Alternatively" instead of right after "implementation", so that this in the same paragraph as the next sentence? One paragraph --> one concept is easier to skim through for relevant information.
Follow up PR to #6407, adds
capabilities
to the device API.[sc-71716]
[sc-71709]