Rename gradient_fn to diff_method in qml.execute
#6549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6549 +/- ##
==========================================
+ Coverage 99.17% 99.34% +0.16%
==========================================
Files 456 456
Lines 43254 43273 +19
==========================================
+ Hits 42899 42989 +90
+ Misses 355 284 -71 ☔ View full report in Codecov by Sentry. |
albi3ro
commented
Nov 8, 2024
andrijapau
approved these changes
Nov 8, 2024
astralcai
approved these changes
Nov 8, 2024
This was referenced Nov 12, 2024
andrijapau
added a commit
to PennyLaneAI/qml
that referenced
this pull request
Nov 12, 2024
**Summary:** Updating deprecated code that was introduced from a recent deprecation PennyLaneAI/pennylane#6549. [sc-77590]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
We use the term
diff_methodin theQNodeandgradient_fninqml.execute. This can cause confusion having two different terms for basically the same thing.Description of the Change:
Deprecates the term
gradient_fnand strictly usesdiff_methodinqml.execute.Benefits:
Increased consistency in terminology. Opens us to preprocessing the
diff_methodinside ofqml.execute, making it more robust and user-friendly.Possible Drawbacks:
Deprecations can always cause problems. This is an easy change, as it can be handled by a find-replace automation, but that is always extra work.
Related GitHub Issues:
[sc-77590]