-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a separate pylintrc for labs tests #6553
base: master
Are you sure you want to change the base?
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6553 +/- ##
==========================================
+ Coverage 99.17% 99.34% +0.16%
==========================================
Files 456 456
Lines 43254 43273 +19
==========================================
+ Hits 42899 42989 +90
+ Misses 355 284 -71 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @rashidnhm !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I left one suggestions about adding black and isort to the same workflow. Otherwise LGTM. That codefactor issue is weird as well. Looks like a pylint bug that was resolved in 2.7.5 (context). We use 2.7.4 🫠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final comment, otherwise ready to go.
Context: Adding a separate pylintrc for pennylane labs tests
Description of the Change:
This PR adds a new pylintrc file for pennylane labs tests.
The pennylane/labs/tests directory is excluded from linting from the root pylintrc file, this is required as the tests reside within pennylane folder itself.
The tests/.pylintrc file was copied over to be used for labs. The reason for introducing a new file instead of using the existing one in tests/ is so it allows us to easily diverge the configs in the future if necessary!
A new workflow was introduced that will only run if pennylane/labs/** was updated
Benefits:
Separate linting for labs.
Possible Drawbacks:
Related GitHub Issues:
sc-77561