Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_include_mskip_file: push only pure lines (no multiple "\n") #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dolmen
Copy link
Member

@dolmen dolmen commented May 28, 2015

sub _include_mskip_file returns an array of strings that are supposed to be lines.
But some of them aren't:

  • "\n#!start included $mskip\n"
  • "#!end included $mskip\n\n"

Review on Reviewable

@dolmen dolmen force-pushed the fix/_include_mskip_file-push-pure-lines branch from 3d17e6b to f2a9267 Compare January 17, 2017 16:31
@dolmen
Copy link
Member Author

dolmen commented Apr 12, 2017

OK for merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants